Change SelectionModifier::ModifyMovingLeft() not to use redundant local variable

Change SelectionModifier::ModifyMovingLeft() not to use redundant local variable

This patch replaces redundant local variable |pop| with |return| statement in
|SelectionModifier::ModifyMovingLeft()| to simplify and switches then-clause
and else-clause to reduce indentation for improving code health.

This patch also adds |NOTREACHED()| to catch unexpected cases.

This patch is a preparation of adopting |SelectionModifier| to Layout NG.

BUG=707656
TEST=n/a;

Review-Url: https://codereview.chromium.org/2904813006
Cr-Commit-Position: refs/heads/master@{#475071}
Committed: https://chromium.googlesource.com/chromium/src/+/92f32265bc3c70ee7f5e75993207fc72e91d2789

[yosin_UTC9, 2017-05-26 10:17:19]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-26 10:17:31]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yosin_UTC9, 2017-05-26 10:19:00]

Description was changed from

==========
2017-05-26T19:15:35

BUG=707656

2017-05-26T19:15:29
==========

to

==========
Change SelectionModifier::ModifyMovingLeft() not to use redundant local variable

This patch replaces redundant local variable |pop| with |return| statement in
|SelectionModifier::ModifyMovingLeft()| to simplify it for improving code
health.

This patch is a preparation of adopting |SelectionModifier| to Layout NG.

BUG=707656
TEST=n/a;
==========

[yosin_UTC9, 2017-05-26 10:19:32]

yosin@chromium.org changed reviewers:
+ xiaochengh@chromium.org, yoichio@chromium.org

[yosin_UTC9, 2017-05-26 10:19:32]

PTAL

Please click [Commit] if this patch is OK to commit.
Thanks!

[yosin_UTC9, 2017-05-26 10:20:41]

Description was changed from

==========
Change SelectionModifier::ModifyMovingLeft() not to use redundant local variable

This patch replaces redundant local variable |pop| with |return| statement in
|SelectionModifier::ModifyMovingLeft()| to simplify it for improving code
health.

This patch is a preparation of adopting |SelectionModifier| to Layout NG.

BUG=707656
TEST=n/a;
==========

to

==========
Change SelectionModifier::ModifyMovingLeft() not to use redundant local variable

This patch replaces redundant local variable |pop| with |return| statement in
|SelectionModifier::ModifyMovingLeft()| to simplify and switches then-clause
and else-clause to reduce indentation for improving code health.

This patch is a preparation of adopting |SelectionModifier| to Layout NG.

BUG=707656
TEST=n/a;
==========

[yosin_UTC9, 2017-05-26 10:21:42]

Description was changed from

==========
Change SelectionModifier::ModifyMovingLeft() not to use redundant local variable

This patch replaces redundant local variable |pop| with |return| statement in
|SelectionModifier::ModifyMovingLeft()| to simplify and switches then-clause
and else-clause to reduce indentation for improving code health.

This patch is a preparation of adopting |SelectionModifier| to Layout NG.

BUG=707656
TEST=n/a;
==========

to

==========
Change SelectionModifier::ModifyMovingLeft() not to use redundant local variable

This patch replaces redundant local variable |pop| with |return| statement in
|SelectionModifier::ModifyMovingLeft()| to simplify and switches then-clause
and else-clause to reduce indentation for improving code health.

This patch also adds |NOTREACHED()| to catch unexpected cases.

This patch is a preparation of adopting |SelectionModifier| to Layout NG.

BUG=707656
TEST=n/a;
==========

[commit-bot: I haz the power, 2017-05-26 14:19:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-26 14:19:03]

Dry run: This issue passed the CQ dry run.

[Xiaocheng, 2017-05-26 18:37:54]

The CQ bit was checked by xiaochengh@chromium.org

[Xiaocheng, 2017-05-26 18:37:55]

lgtm

[commit-bot: I haz the power, 2017-05-26 18:38:44]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-26 18:43:17]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1495823874586760, "parent_rev":
"802826d9bacfad322a4ec415373d1ed3f317a2a2", "commit_rev":
"92f32265bc3c70ee7f5e75993207fc72e91d2789"}

[commit-bot: I haz the power, 2017-05-26 18:43:30]

Description was changed from

==========
Change SelectionModifier::ModifyMovingLeft() not to use redundant local variable

This patch replaces redundant local variable |pop| with |return| statement in
|SelectionModifier::ModifyMovingLeft()| to simplify and switches then-clause
and else-clause to reduce indentation for improving code health.

This patch also adds |NOTREACHED()| to catch unexpected cases.

This patch is a preparation of adopting |SelectionModifier| to Layout NG.

BUG=707656
TEST=n/a;
==========

to

==========
Change SelectionModifier::ModifyMovingLeft() not to use redundant local variable

This patch replaces redundant local variable |pop| with |return| statement in
|SelectionModifier::ModifyMovingLeft()| to simplify and switches then-clause
and else-clause to reduce indentation for improving code health.

This patch also adds |NOTREACHED()| to catch unexpected cases.

This patch is a preparation of adopting |SelectionModifier| to Layout NG.

BUG=707656
TEST=n/a;

Review-Url: https://codereview.chromium.org/2904813006
Cr-Commit-Position: refs/heads/master@{#475071}
Committed:
https://chromium.googlesource.com/chromium/src/+/92f32265bc3c70ee7f5e75993207...
==========

[commit-bot: I haz the power, 2017-05-26 18:43:32]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/92f32265bc3c70ee7f5e75993207...