Wrap text node handling code in TextIterator into wrapper functions

Wrap text node handling code in TextIterator into wrapper functions

This patch introduces wrapper functions to wrap some text node handling
code that is not in dedicated functions yet. A followup patch will remove
these functions and the data members that they use into a wrapper class.

BUG=721957
TEST=n/a; no behavioral change

Review-Url: https://codereview.chromium.org/2904813003
Cr-Commit-Position: refs/heads/master@{#475243}
Committed: https://chromium.googlesource.com/chromium/src/+/d555fc27510ae3b0c155bfabc089f67edf412bda

[Xiaocheng, 2017-05-25 06:07:14]

Description was changed from

==========
Wrap text node handling code in TextIterator into wrapper functions

BUG=
==========

to

==========
Wrap text node handling code in TextIterator into wrapper functions

This patch introduces wrapper functions to wrap some text node handling
code that is not in dedicated functions yet. A followup patch will remove
these functions and the data members that they use into a wrapper class.

BUG=721957
TEST=n/a; no behavioral change
==========

[Xiaocheng, 2017-05-25 06:12:57]

xiaochengh@chromium.org changed reviewers:
+ yosin@chromium.org

[Xiaocheng, 2017-05-25 06:12:58]

PTAL.

[yosin_UTC9, 2017-05-25 06:24:51]

lgtm w/ nits

https://codereview.chromium.org/2904813003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/iterators/TextIterator.cpp (right):

https://codereview.chromium.org/2904813003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/iterators/TextIterator.cpp:276: if
(needs_handle_pre_formatted_text_node_) {
nit: Too reduce indentation, let's write

if (!needs_handle_pre_formatted_text_node_)
  return false;
....

https://codereview.chromium.org/2904813003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/iterators/TextIterator.cpp:890: if
(text_node_) {
nit: too reduce indentation. Let's write

if (!text_node_)
  return false;

....

[Xiaocheng, 2017-05-25 23:07:26]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-25 23:08:14]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xiaocheng, 2017-05-25 23:15:34]

https://codereview.chromium.org/2904813003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/iterators/TextIterator.cpp (right):

https://codereview.chromium.org/2904813003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/iterators/TextIterator.cpp:276: if
(needs_handle_pre_formatted_text_node_) {
On 2017/05/25 at 06:24:51, yosin_UTC9 wrote:
> nit: Too reduce indentation, let's write
> 
> if (!needs_handle_pre_formatted_text_node_)
>   return false;
> ....

Done.

https://codereview.chromium.org/2904813003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/iterators/TextIterator.cpp:890: if
(text_node_) {
On 2017/05/25 at 06:24:51, yosin_UTC9 wrote:
> nit: too reduce indentation. Let's write
> 
> if (!text_node_)
>   return false;
> 
> ....

Not applicable as this part is changed in the latest patch set.

[commit-bot: I haz the power, 2017-05-26 01:25:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-26 01:25:31]

Dry run: This issue passed the CQ dry run.

[Xiaocheng, 2017-05-26 21:52:19]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-26 21:52:59]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-26 21:58:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-26 21:58:13]

Dry run: This issue passed the CQ dry run.

[Xiaocheng, 2017-05-27 02:48:04]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-27 02:48:13]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-27 04:34:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-27 04:34:23]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Xiaocheng, 2017-05-27 06:06:18]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-27 06:06:25]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xiaocheng, 2017-05-27 06:33:45]

The CQ bit was unchecked by xiaochengh@chromium.org

[Xiaocheng, 2017-05-27 06:33:50]

The CQ bit was checked by xiaochengh@chromium.org

[Xiaocheng, 2017-05-27 06:33:50]

The patchset sent to the CQ was uploaded after l-g-t-m from yosin@chromium.org
Link to the patchset: https://codereview.chromium.org/2904813003/#ps20001
(title: "Thu May 25 16:06:45 PDT 2017")

[commit-bot: I haz the power, 2017-05-27 06:34:04]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-27 06:49:00]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1495866830386010,
"parent_rev": "d1b64ea824a10da503d0ee572442cb3119c3d2ed", "commit_rev":
"d555fc27510ae3b0c155bfabc089f67edf412bda"}

[commit-bot: I haz the power, 2017-05-27 06:49:11]

Description was changed from

==========
Wrap text node handling code in TextIterator into wrapper functions

This patch introduces wrapper functions to wrap some text node handling
code that is not in dedicated functions yet. A followup patch will remove
these functions and the data members that they use into a wrapper class.

BUG=721957
TEST=n/a; no behavioral change
==========

to

==========
Wrap text node handling code in TextIterator into wrapper functions

This patch introduces wrapper functions to wrap some text node handling
code that is not in dedicated functions yet. A followup patch will remove
these functions and the data members that they use into a wrapper class.

BUG=721957
TEST=n/a; no behavioral change

Review-Url: https://codereview.chromium.org/2904813003
Cr-Commit-Position: refs/heads/master@{#475243}
Committed:
https://chromium.googlesource.com/chromium/src/+/d555fc27510ae3b0c155bfabc089...
==========

[commit-bot: I haz the power, 2017-05-27 06:49:12]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/d555fc27510ae3b0c155bfabc089...