Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 2904783003: Allow user to select text in Settings UI (Closed)

Created:
3 years, 7 months ago by Gaja
Modified:
3 years, 5 months ago
Reviewers:
dschuyler
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Allow user to select text in Settings UI This lets user to do a Google search for the text to learn more about it. The old Settings UI as well allowed the text to be selected. BUG=691783 R=dschuyler@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2904783003 Cr-Commit-Position: refs/heads/master@{#479982} Committed: https://chromium.googlesource.com/chromium/src/+/0721d307c2e650409d287b02ddeeed4d1635b086

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/resources/settings/settings_ui/settings_ui.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
Gaja
Please take a look. Thanks.
3 years, 7 months ago (2017-05-24 10:38:15 UTC) #2
dschuyler
On 2017/05/24 10:38:15, Gaja wrote: > Please take a look. Thanks. I made a note ...
3 years, 7 months ago (2017-05-24 21:22:45 UTC) #3
dschuyler
Alan says he's good with it. lgtm
3 years, 6 months ago (2017-06-15 21:31:57 UTC) #4
Gaja
On 2017/06/15 21:31:57, dschuyler wrote: > Alan says he's good with it. lgtm Thank You.
3 years, 6 months ago (2017-06-16 04:24:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2904783003/1
3 years, 6 months ago (2017-06-16 04:25:06 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/0721d307c2e650409d287b02ddeeed4d1635b086
3 years, 6 months ago (2017-06-16 07:37:10 UTC) #10
dpapad
3 years, 5 months ago (2017-06-30 18:38:57 UTC) #11
Message was sent while issue was closed.
On 2017/06/16 at 07:37:10, commit-bot wrote:
> Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0721d307c2e650409d287b02ddee...

If we are making everything selectable, then the previous logic to enable
selection on specific parts is obsolete and should be remvoved, see
https://cs.chromium.org/search/?q=%22user-select:+text%22+file:%5Esrc/chrome/....

Powered by Google App Engine
This is Rietveld 408576698