Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(843)

Issue 2904763002: dbus: Provide LivenessService.CheckLiveness (Closed)

Created:
3 years, 7 months ago by teravest
Modified:
3 years, 7 months ago
Reviewers:
Daniel Erat
CC:
chromium-reviews, hashimoto+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

dbus: Provide LivenessService.CheckLiveness CheckLiveness is being moved to its own service so that it can be moved outside the browser process for mus+ash. BUG=644322 TEST=Manual dbus-send test on LibCrosService and LivenessService Review-Url: https://codereview.chromium.org/2904763002 Cr-Commit-Position: refs/heads/master@{#474140} Committed: https://chromium.googlesource.com/chromium/src/+/4bb59edb9d55aa56f4e79236e86f081b92c686ef

Patch Set 1 #

Total comments: 2

Patch Set 2 : dbus: Provide LivenessService.CheckLiveness #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -5 lines) Patch
M chrome/browser/chromeos/chrome_browser_main_chromeos.cc View 1 4 chunks +12 lines, -1 line 0 comments Download
M chromeos/dbus/services/liveness_service_provider.h View 2 chunks +6 lines, -1 line 0 comments Download
M chromeos/dbus/services/liveness_service_provider.cc View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
teravest
3 years, 7 months ago (2017-05-23 23:26:53 UTC) #2
Daniel Erat
lgtm https://codereview.chromium.org/2904763002/diff/1/chrome/browser/chromeos/chrome_browser_main_chromeos.cc File chrome/browser/chromeos/chrome_browser_main_chromeos.cc (right): https://codereview.chromium.org/2904763002/diff/1/chrome/browser/chromeos/chrome_browser_main_chromeos.cc#newcode291 chrome/browser/chromeos/chrome_browser_main_chromeos.cc:291: // TODO(teravest): Rmoeve this provider once all callers ...
3 years, 7 months ago (2017-05-23 23:31:43 UTC) #3
teravest
https://codereview.chromium.org/2904763002/diff/1/chrome/browser/chromeos/chrome_browser_main_chromeos.cc File chrome/browser/chromeos/chrome_browser_main_chromeos.cc (right): https://codereview.chromium.org/2904763002/diff/1/chrome/browser/chromeos/chrome_browser_main_chromeos.cc#newcode291 chrome/browser/chromeos/chrome_browser_main_chromeos.cc:291: // TODO(teravest): Rmoeve this provider once all callers are ...
3 years, 7 months ago (2017-05-24 01:33:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2904763002/20001
3 years, 7 months ago (2017-05-24 01:35:36 UTC) #7
commit-bot: I haz the power
3 years, 7 months ago (2017-05-24 02:56:54 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/4bb59edb9d55aa56f4e79236e86f...

Powered by Google App Engine
This is Rietveld 408576698