Switch VS 2017 builds to VS 2017 Update 3 Preview 1

Switch VS 2017 builds to VS 2017 Update 3 Preview 1

This change switches the VS 2017 package to use the first Update 3
Preview.

Packaging was done on a Windows Server 2016 VM, cleanly created for this
purpose.

Compiler was packaged up by downloading the VS 2017 Update 3 Preview 1,
from https://www.visualstudio.com/vs/preview/, and then running this
command (executable name was different):

    vs_professional.exe --add Microsoft.VisualStudio.Workload.NativeDesktop
    --add Microsoft.VisualStudio.Component.VC.ATLMFC --includeRecommended
    --passive

Then the Windows 10.0.14393.0 SDK (10.0.14393.795, to be precise) was
installed, necessary because Chrome currently requires that SDK. This
also installs the x86 and x64 debuggers.

Then statreg.h in the VS install was patched to add constexpr for
clang-cl (but not for VC++, which can't handle it), per this bug:

https://developercommunity.visualstudio.com/content/problem/58907/statregh-doesnt-compile-with-clang-cl-constconstex.html

The patched version is attached to this bug comment:
    https://bugs.chromium.org/p/chromium/issues/detail?id=683729#c113

Finally the packaging script (updated in
https://chromium-review.googlesource.com/516442) was run:

    python depot_tools\win_toolchain\package_from_installed.py 2017 -w 10.0.14393.0

VS 2015 builds are still the default.

R=scottmg@chromium.org
BUG=683729
Review-Url: https://codereview.chromium.org/2904733004
Cr-Commit-Position: refs/heads/master@{#475088}
Committed: https://chromium.googlesource.com/chromium/src/+/bc58befabe87e204650c836793204bac887992bd

[brucedawson, 2017-05-25 18:25:45]

The CQ bit was checked by brucedawson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-25 18:26:42]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-25 19:40:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-25 19:40:42]

Dry run: This issue passed the CQ dry run.

[brucedawson, 2017-05-25 20:02:23]

The CQ bit was checked by brucedawson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-25 20:03:12]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-25 22:01:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-25 22:01:18]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[brucedawson, 2017-05-25 23:08:58]

The CQ bit was checked by brucedawson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-25 23:09:36]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[brucedawson, 2017-05-25 23:16:28]

The CQ bit was checked by brucedawson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-25 23:17:37]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[brucedawson, 2017-05-25 23:22:37]

Description was changed from

==========
VS 2017 preview test

BUG=683729
==========

to

==========
Switch VS 2017 builds to VS 2017 Update 3 Preview 1

This change switches the VS 2017 package.

Packaging was done on a Windows Server 2016 VM, cleanly created for this
purpose.

Compiler was packaged up by downloading the VS 2017 Update 3 Preview 1,
from https://www.visualstudio.com/vs/preview/, and then running this
command (executable name was different):

    vs_professional.exe --add Microsoft.VisualStudio.Workload.NativeDesktop
    --add Microsoft.VisualStudio.Component.VC.ATLMFC --includeRecommended
    --passive

Then the Windows 10.0.14393.0 SDK was installed, which also installed the
x86 and x64 debuggers.

Then statreg.h in the VS install was patched to add constexpr where
needed for clang-cl compatibility, per this bug:

https://developercommunity.visualstudio.com/content/problem/58907/statregh-do...

Finally the recently updated packaging script was run:

    python depot_tools\win_toolchain\package_from_installed.py 2017 -w
10.0.14393.0

R=scottmg@chromium.org
BUG=683729
==========

[brucedawson, 2017-05-25 23:22:37]

brucedawson@chromium.org changed reviewers:
+ scottmg@chromium.org

[brucedawson, 2017-05-25 23:36:49]

The CQ bit was checked by brucedawson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-25 23:37:33]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-26 00:34:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-26 00:34:57]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[brucedawson, 2017-05-26 01:00:18]

Description was changed from

==========
Switch VS 2017 builds to VS 2017 Update 3 Preview 1

This change switches the VS 2017 package.

Packaging was done on a Windows Server 2016 VM, cleanly created for this
purpose.

Compiler was packaged up by downloading the VS 2017 Update 3 Preview 1,
from https://www.visualstudio.com/vs/preview/, and then running this
command (executable name was different):

    vs_professional.exe --add Microsoft.VisualStudio.Workload.NativeDesktop
    --add Microsoft.VisualStudio.Component.VC.ATLMFC --includeRecommended
    --passive

Then the Windows 10.0.14393.0 SDK was installed, which also installed the
x86 and x64 debuggers.

Then statreg.h in the VS install was patched to add constexpr where
needed for clang-cl compatibility, per this bug:

https://developercommunity.visualstudio.com/content/problem/58907/statregh-do...

Finally the recently updated packaging script was run:

    python depot_tools\win_toolchain\package_from_installed.py 2017 -w
10.0.14393.0

R=scottmg@chromium.org
BUG=683729
==========

to

==========
Switch VS 2017 builds to VS 2017 Update 3 Preview 1

This change switches the VS 2017 package to use the first Update 3
Preview.

Packaging was done on a Windows Server 2016 VM, cleanly created for this
purpose.

Compiler was packaged up by downloading the VS 2017 Update 3 Preview 1,
from https://www.visualstudio.com/vs/preview/, and then running this
command (executable name was different):

    vs_professional.exe --add Microsoft.VisualStudio.Workload.NativeDesktop
    --add Microsoft.VisualStudio.Component.VC.ATLMFC --includeRecommended
    --passive

Then the Windows 10.0.14393.0 SDK was installed, which also installed the
x86 and x64 debuggers.

Then statreg.h in the VS install was patched to add constexpr for clang-cl
(but not for VC++, which can't handle it), per this bug:

https://developercommunity.visualstudio.com/content/problem/58907/statregh-do...

Finally the recently updated packaging script was run:

    python depot_tools\win_toolchain\package_from_installed.py 2017 -w
10.0.14393.0

R=scottmg@chromium.org
BUG=683729
==========

[brucedawson, 2017-05-26 01:08:36]

The CQ bit was checked by brucedawson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-26 01:09:35]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-26 05:36:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-26 05:36:17]

Dry run: This issue passed the CQ dry run.

[brucedawson, 2017-05-26 17:03:18]

Description was changed from

==========
Switch VS 2017 builds to VS 2017 Update 3 Preview 1

This change switches the VS 2017 package to use the first Update 3
Preview.

Packaging was done on a Windows Server 2016 VM, cleanly created for this
purpose.

Compiler was packaged up by downloading the VS 2017 Update 3 Preview 1,
from https://www.visualstudio.com/vs/preview/, and then running this
command (executable name was different):

    vs_professional.exe --add Microsoft.VisualStudio.Workload.NativeDesktop
    --add Microsoft.VisualStudio.Component.VC.ATLMFC --includeRecommended
    --passive

Then the Windows 10.0.14393.0 SDK was installed, which also installed the
x86 and x64 debuggers.

Then statreg.h in the VS install was patched to add constexpr for clang-cl
(but not for VC++, which can't handle it), per this bug:

https://developercommunity.visualstudio.com/content/problem/58907/statregh-do...

Finally the recently updated packaging script was run:

    python depot_tools\win_toolchain\package_from_installed.py 2017 -w
10.0.14393.0

R=scottmg@chromium.org
BUG=683729
==========

to

==========
Switch VS 2017 builds to VS 2017 Update 3 Preview 1

This change switches the VS 2017 package to use the first Update 3
Preview.

Packaging was done on a Windows Server 2016 VM, cleanly created for this
purpose.

Compiler was packaged up by downloading the VS 2017 Update 3 Preview 1,
from https://www.visualstudio.com/vs/preview/, and then running this
command (executable name was different):

    vs_professional.exe --add Microsoft.VisualStudio.Workload.NativeDesktop
    --add Microsoft.VisualStudio.Component.VC.ATLMFC --includeRecommended
    --passive

Then the Windows 10.0.14393.0 SDK (10.0.14393.795, to be precise) was
installed, which also installed the x86 and x64 debuggers.

Then statreg.h in the VS install was patched to add constexpr for clang-cl
(but not for VC++, which can't handle it), per this bug:

https://developercommunity.visualstudio.com/content/problem/58907/statregh-do...

Finally the recently updated packaging script was run:

    python depot_tools\win_toolchain\package_from_installed.py 2017 -w
10.0.14393.0

R=scottmg@chromium.org
BUG=683729
==========

[brucedawson, 2017-05-26 17:10:21]

Description was changed from

==========
Switch VS 2017 builds to VS 2017 Update 3 Preview 1

This change switches the VS 2017 package to use the first Update 3
Preview.

Packaging was done on a Windows Server 2016 VM, cleanly created for this
purpose.

Compiler was packaged up by downloading the VS 2017 Update 3 Preview 1,
from https://www.visualstudio.com/vs/preview/, and then running this
command (executable name was different):

    vs_professional.exe --add Microsoft.VisualStudio.Workload.NativeDesktop
    --add Microsoft.VisualStudio.Component.VC.ATLMFC --includeRecommended
    --passive

Then the Windows 10.0.14393.0 SDK (10.0.14393.795, to be precise) was
installed, which also installed the x86 and x64 debuggers.

Then statreg.h in the VS install was patched to add constexpr for clang-cl
(but not for VC++, which can't handle it), per this bug:

https://developercommunity.visualstudio.com/content/problem/58907/statregh-do...

Finally the recently updated packaging script was run:

    python depot_tools\win_toolchain\package_from_installed.py 2017 -w
10.0.14393.0

R=scottmg@chromium.org
BUG=683729
==========

to

==========
Switch VS 2017 builds to VS 2017 Update 3 Preview 1

This change switches the VS 2017 package to use the first Update 3
Preview.

Packaging was done on a Windows Server 2016 VM, cleanly created for this
purpose.

Compiler was packaged up by downloading the VS 2017 Update 3 Preview 1,
from https://www.visualstudio.com/vs/preview/, and then running this
command (executable name was different):

    vs_professional.exe --add Microsoft.VisualStudio.Workload.NativeDesktop
    --add Microsoft.VisualStudio.Component.VC.ATLMFC --includeRecommended
    --passive

Then the Windows 10.0.14393.0 SDK (10.0.14393.795, to be precise) was
installed, necessary because Chrome currently requires that SDK. This also
installs the x86 and x64 debuggers.

Then statreg.h in the VS install was patched to add constexpr for clang-cl
(but not for VC++, which can't handle it), per this bug:

https://developercommunity.visualstudio.com/content/problem/58907/statregh-do...

The patched version is attached to this bug comment:
    https://bugs.chromium.org/p/chromium/issues/detail?id=683729#c113

Finally the recently updated packaging script was run:

    python depot_tools\win_toolchain\package_from_installed.py 2017 -w
10.0.14393.0

VS 2015 builds are still the default.

R=scottmg@chromium.org
BUG=683729
==========

[brucedawson, 2017-05-26 17:16:55]

Description was changed from

==========
Switch VS 2017 builds to VS 2017 Update 3 Preview 1

This change switches the VS 2017 package to use the first Update 3
Preview.

Packaging was done on a Windows Server 2016 VM, cleanly created for this
purpose.

Compiler was packaged up by downloading the VS 2017 Update 3 Preview 1,
from https://www.visualstudio.com/vs/preview/, and then running this
command (executable name was different):

    vs_professional.exe --add Microsoft.VisualStudio.Workload.NativeDesktop
    --add Microsoft.VisualStudio.Component.VC.ATLMFC --includeRecommended
    --passive

Then the Windows 10.0.14393.0 SDK (10.0.14393.795, to be precise) was
installed, necessary because Chrome currently requires that SDK. This also
installs the x86 and x64 debuggers.

Then statreg.h in the VS install was patched to add constexpr for clang-cl
(but not for VC++, which can't handle it), per this bug:

https://developercommunity.visualstudio.com/content/problem/58907/statregh-do...

The patched version is attached to this bug comment:
    https://bugs.chromium.org/p/chromium/issues/detail?id=683729#c113

Finally the recently updated packaging script was run:

    python depot_tools\win_toolchain\package_from_installed.py 2017 -w
10.0.14393.0

VS 2015 builds are still the default.

R=scottmg@chromium.org
BUG=683729
==========

to

==========
Switch VS 2017 builds to VS 2017 Update 3 Preview 1

This change switches the VS 2017 package to use the first Update 3
Preview.

Packaging was done on a Windows Server 2016 VM, cleanly created for this
purpose.

Compiler was packaged up by downloading the VS 2017 Update 3 Preview 1,
from https://www.visualstudio.com/vs/preview/, and then running this
command (executable name was different):

    vs_professional.exe --add Microsoft.VisualStudio.Workload.NativeDesktop
    --add Microsoft.VisualStudio.Component.VC.ATLMFC --includeRecommended
    --passive

Then the Windows 10.0.14393.0 SDK (10.0.14393.795, to be precise) was
installed, necessary because Chrome currently requires that SDK. This also
installs the x86 and x64 debuggers.

Then statreg.h in the VS install was patched to add constexpr for clang-cl
(but not for VC++, which can't handle it), per this bug:

https://developercommunity.visualstudio.com/content/problem/58907/statregh-do...

The patched version is attached to this bug comment:
    https://bugs.chromium.org/p/chromium/issues/detail?id=683729#c113

Finally the packaging script (updated in
https://chromium-review.googlesource.com/516442) was run:

    python depot_tools\win_toolchain\package_from_installed.py 2017 -w
10.0.14393.0

VS 2015 builds are still the default.

R=scottmg@chromium.org
BUG=683729
==========

[brucedawson, 2017-05-26 17:36:33]

Description was changed from

==========
Switch VS 2017 builds to VS 2017 Update 3 Preview 1

This change switches the VS 2017 package to use the first Update 3
Preview.

Packaging was done on a Windows Server 2016 VM, cleanly created for this
purpose.

Compiler was packaged up by downloading the VS 2017 Update 3 Preview 1,
from https://www.visualstudio.com/vs/preview/, and then running this
command (executable name was different):

    vs_professional.exe --add Microsoft.VisualStudio.Workload.NativeDesktop
    --add Microsoft.VisualStudio.Component.VC.ATLMFC --includeRecommended
    --passive

Then the Windows 10.0.14393.0 SDK (10.0.14393.795, to be precise) was
installed, necessary because Chrome currently requires that SDK. This also
installs the x86 and x64 debuggers.

Then statreg.h in the VS install was patched to add constexpr for clang-cl
(but not for VC++, which can't handle it), per this bug:

https://developercommunity.visualstudio.com/content/problem/58907/statregh-do...

The patched version is attached to this bug comment:
    https://bugs.chromium.org/p/chromium/issues/detail?id=683729#c113

Finally the packaging script (updated in
https://chromium-review.googlesource.com/516442) was run:

    python depot_tools\win_toolchain\package_from_installed.py 2017 -w
10.0.14393.0

VS 2015 builds are still the default.

R=scottmg@chromium.org
BUG=683729
==========

to

==========
Switch VS 2017 builds to VS 2017 Update 3 Preview 1

This change switches the VS 2017 package to use the first Update 3
Preview.

Packaging was done on a Windows Server 2016 VM, cleanly created for this
purpose.

Compiler was packaged up by downloading the VS 2017 Update 3 Preview 1,
from https://www.visualstudio.com/vs/preview/, and then running this
command (executable name was different):

    vs_professional.exe --add Microsoft.VisualStudio.Workload.NativeDesktop
    --add Microsoft.VisualStudio.Component.VC.ATLMFC --includeRecommended
    --passive

Then the Windows 10.0.14393.0 SDK (10.0.14393.795, to be precise) was
installed, necessary because Chrome currently requires that SDK. This
also installs the x86 and x64 debuggers.

Then statreg.h in the VS install was patched to add constexpr for
clang-cl (but not for VC++, which can't handle it), per this bug:

https://developercommunity.visualstudio.com/content/problem/58907/statregh-do...

The patched version is attached to this bug comment:
    https://bugs.chromium.org/p/chromium/issues/detail?id=683729#c113

Finally the packaging script (updated in
https://chromium-review.googlesource.com/516442) was run:

    python depot_tools\win_toolchain\package_from_installed.py 2017 -w
10.0.14393.0

VS 2015 builds are still the default.

R=scottmg@chromium.org
BUG=683729
==========

[brucedawson, 2017-05-26 17:45:02]

I repackaged VS 2017 - this time VS 2017 Update 3 Preview 1. After updating a
code-gen working around and patching statreg.h everything seems to work.

Note that the updated packaging script has not yet landed due to a depot_tools
bug.

I tested on two VMs and they produced identical results. The packaging process
will be quite simple once the depot_tools and statreg.h changes land.

PTAL

[scottmg, 2017-05-26 17:55:19]

Whew! lgtm

[brucedawson, 2017-05-26 17:58:22]

On 2017/05/26 17:55:19, scottmg wrote:
> Whew! lgtm

I look forward to much simpler packaging instructions in the future.

[brucedawson, 2017-05-26 17:58:29]

The CQ bit was checked by brucedawson@chromium.org

[commit-bot: I haz the power, 2017-05-26 17:58:59]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-26 19:35:01]

CQ is committing da patch.

Bot data: {"patchset_id": 110001, "attempt_start_ts": 1495821509487480,
"parent_rev": "59f676347cd7bb0ec16a9cae0e1257f6548dc3b4", "commit_rev":
"bc58befabe87e204650c836793204bac887992bd"}

[commit-bot: I haz the power, 2017-05-26 19:35:15]

Description was changed from

==========
Switch VS 2017 builds to VS 2017 Update 3 Preview 1

This change switches the VS 2017 package to use the first Update 3
Preview.

Packaging was done on a Windows Server 2016 VM, cleanly created for this
purpose.

Compiler was packaged up by downloading the VS 2017 Update 3 Preview 1,
from https://www.visualstudio.com/vs/preview/, and then running this
command (executable name was different):

    vs_professional.exe --add Microsoft.VisualStudio.Workload.NativeDesktop
    --add Microsoft.VisualStudio.Component.VC.ATLMFC --includeRecommended
    --passive

Then the Windows 10.0.14393.0 SDK (10.0.14393.795, to be precise) was
installed, necessary because Chrome currently requires that SDK. This
also installs the x86 and x64 debuggers.

Then statreg.h in the VS install was patched to add constexpr for
clang-cl (but not for VC++, which can't handle it), per this bug:

https://developercommunity.visualstudio.com/content/problem/58907/statregh-do...

The patched version is attached to this bug comment:
    https://bugs.chromium.org/p/chromium/issues/detail?id=683729#c113

Finally the packaging script (updated in
https://chromium-review.googlesource.com/516442) was run:

    python depot_tools\win_toolchain\package_from_installed.py 2017 -w
10.0.14393.0

VS 2015 builds are still the default.

R=scottmg@chromium.org
BUG=683729
==========

to

==========
Switch VS 2017 builds to VS 2017 Update 3 Preview 1

This change switches the VS 2017 package to use the first Update 3
Preview.

Packaging was done on a Windows Server 2016 VM, cleanly created for this
purpose.

Compiler was packaged up by downloading the VS 2017 Update 3 Preview 1,
from https://www.visualstudio.com/vs/preview/, and then running this
command (executable name was different):

    vs_professional.exe --add Microsoft.VisualStudio.Workload.NativeDesktop
    --add Microsoft.VisualStudio.Component.VC.ATLMFC --includeRecommended
    --passive

Then the Windows 10.0.14393.0 SDK (10.0.14393.795, to be precise) was
installed, necessary because Chrome currently requires that SDK. This
also installs the x86 and x64 debuggers.

Then statreg.h in the VS install was patched to add constexpr for
clang-cl (but not for VC++, which can't handle it), per this bug:

https://developercommunity.visualstudio.com/content/problem/58907/statregh-do...

The patched version is attached to this bug comment:
    https://bugs.chromium.org/p/chromium/issues/detail?id=683729#c113

Finally the packaging script (updated in
https://chromium-review.googlesource.com/516442) was run:

    python depot_tools\win_toolchain\package_from_installed.py 2017 -w
10.0.14393.0

VS 2015 builds are still the default.

R=scottmg@chromium.org
BUG=683729

Review-Url: https://codereview.chromium.org/2904733004
Cr-Commit-Position: refs/heads/master@{#475088}
Committed:
https://chromium.googlesource.com/chromium/src/+/bc58befabe87e204650c83679320...
==========

[commit-bot: I haz the power, 2017-05-26 19:35:17]

Committed patchset #7 (id:110001) as
https://chromium.googlesource.com/chromium/src/+/bc58befabe87e204650c83679320...

[scottmg, 2017-05-26 22:16:22]

(I noticed the package for RTM vs Update3 went from 766M to 844M, seems a bit
surprising? Not important, just curious if you happen to know off hand if
something got added.)

[brucedawson, 2017-05-26 22:47:32]

On 2017/05/26 22:16:22, scottmg wrote:
> (I noticed the package for RTM vs Update3 went from 766M to 844M, seems a bit
> surprising? Not important, just curious if you happen to know off hand if
> something got added.)

I looked with windirstat and that showed a 100 MB increased in the total size of
DLLs (plus general growth everywhere else).

That turns out to be caused primarily by this directory that appeared even
though I packaged the 10.0.14393.0 SDK:

    win_sdk\bin\10.0.15063.0

So yeah, that's a bug in the packaging script. There are a few other 15063
directories that got pulled in. I might try adding better filtering. On the
other hand, the issue will go away once we start packaging with 15063 - there
won't be an "other" SDK to pull in.

Anyway, good observation.