[CRD iOS] Add support for three-finger gestures

[CRD iOS] Add support for three-finger gestures

This CL adds gesture supports for:

* Three-finger tap => inject middle click
* Three-finger swipe => show/hide keyboard

The swipe-down gesture was to show the navigation bar in Android, but let's use
it to hide the keyboard for now.

THis CL also refactors InjectMouseClick a little bit to handle all three button
clicks.

BUG=718704
Review-Url: https://codereview.chromium.org/2904703003
Cr-Commit-Position: refs/heads/master@{#474724}
Committed: https://chromium.googlesource.com/chromium/src/+/e745346e71a014a64f007da11dd719427175d872

[Yuwei, 2017-05-24 00:15:09]

yuweih@chromium.org changed reviewers:
+ nicholss@chromium.org

[Yuwei, 2017-05-24 00:15:10]

PTAL thanks!

[nicholss, 2017-05-24 14:36:49]

Please add a delegate class, otherwise looking good.

As an example:
https://cs.corp.google.com/piper///depot/google3/googlemac/iPhone/Eva/Sources...

https://codereview.chromium.org/2904703003/diff/1/remoting/ios/client_gestures.h
File remoting/ios/client_gestures.h (right):

https://codereview.chromium.org/2904703003/diff/1/remoting/ios/client_gesture...
remoting/ios/client_gestures.h:53: -
(instancetype)initWithHostViewController:(HostViewController*)controller;
I don't think this is a good pattern in Obj-C, you should not be sending in a
full host view controller. The correct way would be to send in the minimum class
required to show the keyboard such as an UIResponder object, or create a small
delegate class that exposes the show/hide keyboard and pass that to the client
gesture class. 

Passing HostViewController tightly couples the application to the current
implementation, which we do not want to do because it will make it hard to
adjust later.

[nicholss, 2017-05-24 14:38:04]

Description was changed from

==========
[CRD iOS] Add support for three-finger gestures

This CL adds gesture supports for:

* Three-finger tap => inject middle click
* Three-finger swipe => show/hide keyboard

The swipe-down gesture was to show the navigation bar in Android, but let's use
it to hide the keyboard for now.

THis CL also refactors InjectMouseClick a little bit to handle all three button
clicks.

BUG=718704
==========

to

==========
[CRD iOS] Add support for three-finger gestures

This CL adds gesture supports for:

* Three-finger tap => inject middle click
* Three-finger swipe => show/hide keyboard

The swipe-down gesture was to show the navigation bar in Android, but let's use
it to hide the keyboard for now.

THis CL also refactors InjectMouseClick a little bit to handle all three button
clicks.

BUG=718704
==========

[Yuwei, 2017-05-24 19:51:49]

PTAL thanks!

[Yuwei, 2017-05-24 19:52:09]

https://codereview.chromium.org/2904703003/diff/1/remoting/ios/client_gestures.h
File remoting/ios/client_gestures.h (right):

https://codereview.chromium.org/2904703003/diff/1/remoting/ios/client_gesture...
remoting/ios/client_gestures.h:53: -
(instancetype)initWithHostViewController:(HostViewController*)controller;
On 2017/05/24 14:36:49, nicholss wrote:
> I don't think this is a good pattern in Obj-C, you should not be sending in a
> full host view controller. The correct way would be to send in the minimum
class
> required to show the keyboard such as an UIResponder object, or create a small
> delegate class that exposes the show/hide keyboard and pass that to the client
> gesture class. 
> 
> Passing HostViewController tightly couples the application to the current
> implementation, which we do not want to do because it will make it hard to
> adjust later.

Done.

[Yuwei, 2017-05-24 22:29:07]

The CQ bit was checked by yuweih@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-24 22:29:53]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-24 22:58:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-24 22:58:47]

Dry run: This issue passed the CQ dry run.

[Yuwei, 2017-05-25 17:36:38]

Ping!

[Yuwei, 2017-05-25 17:39:01]

The CQ bit was checked by yuweih@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-25 17:39:47]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nicholss, 2017-05-25 17:59:19]

lgtm

[Yuwei, 2017-05-25 18:20:03]

The CQ bit was unchecked by yuweih@chromium.org

[Yuwei, 2017-05-25 18:20:11]

The CQ bit was checked by yuweih@chromium.org

[Yuwei, 2017-05-25 18:20:34]

On 2017/05/25 17:59:19, nicholss wrote:
> lgtm

Thanks!

[commit-bot: I haz the power, 2017-05-25 18:20:48]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Yuwei, 2017-05-25 18:32:30]

The CQ bit was unchecked by yuweih@chromium.org

[Yuwei, 2017-05-25 18:32:54]

The CQ bit was checked by yuweih@chromium.org

[commit-bot: I haz the power, 2017-05-25 18:33:35]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-25 18:44:54]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1495737174613460,
"parent_rev": "bd69bbaf57d1b9ac789b61776be21b515d071e04", "commit_rev":
"e745346e71a014a64f007da11dd719427175d872"}

[commit-bot: I haz the power, 2017-05-25 18:45:05]

Description was changed from

==========
[CRD iOS] Add support for three-finger gestures

This CL adds gesture supports for:

* Three-finger tap => inject middle click
* Three-finger swipe => show/hide keyboard

The swipe-down gesture was to show the navigation bar in Android, but let's use
it to hide the keyboard for now.

THis CL also refactors InjectMouseClick a little bit to handle all three button
clicks.

BUG=718704
==========

to

==========
[CRD iOS] Add support for three-finger gestures

This CL adds gesture supports for:

* Three-finger tap => inject middle click
* Three-finger swipe => show/hide keyboard

The swipe-down gesture was to show the navigation bar in Android, but let's use
it to hide the keyboard for now.

THis CL also refactors InjectMouseClick a little bit to handle all three button
clicks.

BUG=718704

Review-Url: https://codereview.chromium.org/2904703003
Cr-Commit-Position: refs/heads/master@{#474724}
Committed:
https://chromium.googlesource.com/chromium/src/+/e745346e71a014a64f007da11dd7...
==========

[commit-bot: I haz the power, 2017-05-25 18:45:06]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/e745346e71a014a64f007da11dd7...