Revert to system Mail app if current default Mail app is no longer there

Revert to system Mail app if current default Mail app is no longer there

If NSUserDefaults refers to a Mail client app that is no longer
installed, report the system Mail client app as the default Mail client.

BUG=725199
TEST=Have Gmail installed and set it as the default. Then delete Gmail app and verify that system Mail app is now reported as the default.

Review-Url: https://codereview.chromium.org/2904663003
Cr-Commit-Position: refs/heads/master@{#474314}
Committed: https://chromium.googlesource.com/chromium/src/+/eec3be70d963ed697890c612db35332d84bbbfb5

[pkl (ping after 24h if needed), 2017-05-23 21:05:58]

pkl@chromium.org changed reviewers:
+ rohitrao@chromium.org

[rohitrao (ping after 24h), 2017-05-24 11:56:58]

lgtm

https://codereview.chromium.org/2904663003/diff/1/ios/chrome/browser/web/mail...
File ios/chrome/browser/web/mailto_url_rewriter.h (right):

https://codereview.chromium.org/2904663003/diff/1/ios/chrome/browser/web/mail...
ios/chrome/browser/web/mailto_url_rewriter.h:22: // If the key in NSUserDefaults
is not set or set but is no longer installed,
"or the corresponding app is no longer installed"

[pkl (ping after 24h if needed), 2017-05-24 15:53:43]

https://codereview.chromium.org/2904663003/diff/1/ios/chrome/browser/web/mail...
File ios/chrome/browser/web/mailto_url_rewriter.h (right):

https://codereview.chromium.org/2904663003/diff/1/ios/chrome/browser/web/mail...
ios/chrome/browser/web/mailto_url_rewriter.h:22: // If the key in NSUserDefaults
is not set or set but is no longer installed,
On 2017/05/24 11:56:58, rohitrao (ping after 24h) wrote:
> "or the corresponding app is no longer installed"

Done.

[pkl (ping after 24h if needed), 2017-05-24 15:53:49]

The CQ bit was checked by pkl@chromium.org

[pkl (ping after 24h if needed), 2017-05-24 15:53:49]

The patchset sent to the CQ was uploaded after l-g-t-m from
rohitrao@chromium.org
Link to the patchset: https://codereview.chromium.org/2904663003/#ps20001
(title: "clarified a comment")

[commit-bot: I haz the power, 2017-05-24 15:54:06]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-24 16:11:00]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1495641229616470,
"parent_rev": "b4b2d1e1fb916471009d5b5393e0851f1a56bab1", "commit_rev":
"eec3be70d963ed697890c612db35332d84bbbfb5"}

[commit-bot: I haz the power, 2017-05-24 16:11:11]

Description was changed from

==========
Revert to system Mail app if current default Mail app is no longer there

If NSUserDefaults refers to a Mail client app that is no longer
installed, report the system Mail client app as the default Mail client.

BUG=725199
TEST=Have Gmail installed and set it as the default. Then delete Gmail app and
verify that system Mail app is now reported as the default.
==========

to

==========
Revert to system Mail app if current default Mail app is no longer there

If NSUserDefaults refers to a Mail client app that is no longer
installed, report the system Mail client app as the default Mail client.

BUG=725199
TEST=Have Gmail installed and set it as the default. Then delete Gmail app and
verify that system Mail app is now reported as the default.

Review-Url: https://codereview.chromium.org/2904663003
Cr-Commit-Position: refs/heads/master@{#474314}
Committed:
https://chromium.googlesource.com/chromium/src/+/eec3be70d963ed697890c612db35...
==========

[commit-bot: I haz the power, 2017-05-24 16:11:12]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/eec3be70d963ed697890c612db35...