Remove some naked |new| statements in favor of MakeUnique.

Remove some naked |new| statements in favor of MakeUnique.

* Call MakeUnique instead of new;
* use auto type where it does not hurt readability;
* use unique_ptr instead of raw pointers in HttpCacheTest;
* do not unnecessarily upcast HttpNetworkTransaction to HttpTransaction
  in HttpNetworkTransactionTests;
* add/remove includes as needed.

Review-Url: https://codereview.chromium.org/2904643002
Cr-Commit-Position: refs/heads/master@{#474633}
Committed: https://chromium.googlesource.com/chromium/src/+/87dcefcd9544094a19def2688f7bcde92524560d

[Bence, 2017-05-23 18:45:57]

The CQ bit was checked by bnc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-23 18:46:37]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-23 19:42:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-23 19:42:18]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Bence, 2017-05-23 22:57:37]

The CQ bit was checked by bnc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-23 22:58:18]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-24 00:54:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-24 00:54:18]

Dry run: This issue passed the CQ dry run.

[Bence, 2017-05-24 11:30:37]

bnc@chromium.org changed reviewers:
+ mgersh@chromium.org

[Bence, 2017-05-24 11:30:38]

mgersh: PTAL.  Thank you.

See
https://groups.google.com/a/chromium.org/forum/#!msg/chromium-dev/evQtLFgfmyM...
for context.

[mgersh, 2017-05-24 15:26:40]

lgtm (with a note about your include-fixing tool doing something weird)

https://codereview.chromium.org/2904643002/diff/20001/net/http/http_network_t...
File net/http/http_network_transaction.cc (right):

https://codereview.chromium.org/2904643002/diff/20001/net/http/http_network_t...
net/http/http_network_transaction.cc:8: #include <string>
(see comment on .h file)

https://codereview.chromium.org/2904643002/diff/20001/net/http/http_network_t...
File net/http/http_network_transaction.h (left):

https://codereview.chromium.org/2904643002/diff/20001/net/http/http_network_t...
net/http/http_network_transaction.h:11: #include <string>
Not sure why this was deleted, it looks like it's still used.

[Bence, 2017-05-24 15:44:21]

The CQ bit was checked by bnc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-24 15:44:42]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Bence, 2017-05-24 15:44:56]

bnc@chromium.org changed reviewers:
+ xunjieli@chromium.org

[Bence, 2017-05-24 15:44:57]

xunjieli: PTAL, thanks.
mgersh: thank you for reviewing!

https://codereview.chromium.org/2904643002/diff/20001/net/http/http_network_t...
File net/http/http_network_transaction.cc (right):

https://codereview.chromium.org/2904643002/diff/20001/net/http/http_network_t...
net/http/http_network_transaction.cc:8: #include <string>
On 2017/05/24 15:26:40, mgersh wrote:
> (see comment on .h file)

Reverted.

https://codereview.chromium.org/2904643002/diff/20001/net/http/http_network_t...
File net/http/http_network_transaction.h (left):

https://codereview.chromium.org/2904643002/diff/20001/net/http/http_network_t...
net/http/http_network_transaction.h:11: #include <string>
On 2017/05/24 15:26:40, mgersh wrote:
> Not sure why this was deleted, it looks like it's still used.

Reverted.  I am sorry for the oversight.  Since string is only used by
reference, I thought a forward declaration would be enough (which I forgot to
add anyway), but common wisdom seems to be that whenever std::string is
referenced, the best thing is just to include the header.  (It's a typedef so
it's not possible to forward declare, consequently there's no forward declare
header for it.)

[xunjieli, 2017-05-24 15:47:55]

lgtm

[commit-bot: I haz the power, 2017-05-24 17:01:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-24 17:01:50]

Dry run: This issue passed the CQ dry run.

[Bence, 2017-05-25 12:43:25]

The CQ bit was checked by bnc@chromium.org

[Bence, 2017-05-25 12:43:26]

The patchset sent to the CQ was uploaded after l-g-t-m from mgersh@chromium.org
Link to the patchset: https://codereview.chromium.org/2904643002/#ps40001
(title: "Re: #11.")

[commit-bot: I haz the power, 2017-05-25 12:43:33]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-25 12:48:02]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1495716205907840,
"parent_rev": "0dfadaecdbd95a4babb5b05a3fc50441b0aba845", "commit_rev":
"87dcefcd9544094a19def2688f7bcde92524560d"}

[commit-bot: I haz the power, 2017-05-25 12:48:13]

Description was changed from

==========
Remove some naked |new| statements in favor of MakeUnique.

* Call MakeUnique instead of new;
* use auto type where it does not hurt readability;
* use unique_ptr instead of raw pointers in HttpCacheTest;
* do not unnecessarily upcast HttpNetworkTransaction to HttpTransaction
  in HttpNetworkTransactionTests;
* add/remove includes as needed.
==========

to

==========
Remove some naked |new| statements in favor of MakeUnique.

* Call MakeUnique instead of new;
* use auto type where it does not hurt readability;
* use unique_ptr instead of raw pointers in HttpCacheTest;
* do not unnecessarily upcast HttpNetworkTransaction to HttpTransaction
  in HttpNetworkTransactionTests;
* add/remove includes as needed.

Review-Url: https://codereview.chromium.org/2904643002
Cr-Commit-Position: refs/heads/master@{#474633}
Committed:
https://chromium.googlesource.com/chromium/src/+/87dcefcd9544094a19def2688f7b...
==========

[commit-bot: I haz the power, 2017-05-25 12:48:14]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/87dcefcd9544094a19def2688f7b...