Cleanup: Remove more unused flag resources or mark them as platform-specific.

Cleanup: Remove more unused flag resources or mark them as platform-specific.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271597

[piman, 2014-05-15 16:57:47]

https://codereview.chromium.org/290463002/diff/1/chrome/browser/about_flags.cc
File chrome/browser/about_flags.cc (right):

https://codereview.chromium.org/290463002/diff/1/chrome/browser/about_flags.c...
chrome/browser/about_flags.cc:1225: #if defined(OS_ANDROID)
Actually, we want this on mac too.

[Lei Zhang, 2014-05-20 02:38:21]

https://codereview.chromium.org/290463002/diff/1/chrome/browser/about_flags.cc
File chrome/browser/about_flags.cc (right):

https://codereview.chromium.org/290463002/diff/1/chrome/browser/about_flags.c...
chrome/browser/about_flags.cc:1225: #if defined(OS_ANDROID)
On 2014/05/15 16:57:47, piman wrote:
> Actually, we want this on mac too.

Are you going to do that in a different CL soon? As is, since
|supported_platforms| == kOsAndroid, this might as well just be inside a #if
defined(OS_ANDROID) block.

[piman, 2014-05-20 02:50:58]

https://codereview.chromium.org/290463002/diff/1/chrome/browser/about_flags.cc
File chrome/browser/about_flags.cc (right):

https://codereview.chromium.org/290463002/diff/1/chrome/browser/about_flags.c...
chrome/browser/about_flags.cc:1225: #if defined(OS_ANDROID)
On 2014/05/20 02:38:21, Lei Zhang wrote:
> On 2014/05/15 16:57:47, piman wrote:
> > Actually, we want this on mac too.
> 
> Are you going to do that in a different CL soon? As is, since
> |supported_platforms| == kOsAndroid, this might as well just be inside a #if
> defined(OS_ANDROID) block.

Basic support just got added last week -
https://codereview.chromium.org/267073003

I'm not sure when Chris intends to add a flag, but I suppose we could do that
soon.

[Lei Zhang, 2014-05-20 03:07:40]

On 2014/05/20 02:50:58, piman wrote:
> I'm not sure when Chris intends to add a flag, but I suppose we could do that
> soon.

Ok, I made the flag android + mac, with a TODO for Chris.

[piman, 2014-05-20 03:33:22]

lgtm

[Lei Zhang, 2014-05-20 03:48:58]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2014-05-20 03:49:57]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/thestig@chromium.org/290463002/20001

[commit-bot: I haz the power, 2014-05-20 06:43:25]

Change committed as 271597