Cleanup: Remove more unused flag resources or mark them as platform-specific.

chrome/browser/about_flags.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/about_flags.h"
 
 #include <algorithm>
 #include <iterator>
 #include <map>
 #include <set>
 #include <utility>
 
-#include "ash/ash_switches.h"
 #include "base/command_line.h"
 #include "base/memory/singleton.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/values.h"
 #include "cc/base/switches.h"
 #include "chrome/browser/bookmarks/enhanced_bookmarks_features.h"
 #include "chrome/browser/flags_storage.h"
 #include "chrome/common/chrome_content_client.h"
 #include "chrome/common/chrome_switches.h"
@@ skipping 68 matching lines @@
   };
   for (size_t i = 0; i < ARRAYSIZE_UNSAFE(kBitsToOs); ++i)
     if (bitmask & kBitsToOs[i].bit)
       list->Append(new base::StringValue(kBitsToOs[i].name));
 }
 
 // Convert switch constants to proper CommandLine::StringType strings.
 CommandLine::StringType GetSwitchString(const std::string& flag) {
   CommandLine cmd_line(CommandLine::NO_PROGRAM);
   cmd_line.AppendSwitch(flag);
-  DCHECK(cmd_line.argv().size() == 2);
+  DCHECK_EQ(2U, cmd_line.argv().size());
   return cmd_line.argv()[1];
 }
 
 // Scoops flags from a command line.
 std::set<CommandLine::StringType> ExtractFlagsFromCommandLine(
     const CommandLine& cmdline) {
   std::set<CommandLine::StringType> flags;
   // First do the ones between --flag-switches-begin and --flag-switches-end.
   CommandLine::StringVector::const_iterator first =
       std::find(cmdline.argv().begin(), cmdline.argv().end(),
@@ skipping 1103 matching lines @@
     kOsAll,
     MULTI_VALUE_TYPE(kImplSidePaintingChoices)
   },
   {
     "lcd-text-aa",
     IDS_FLAGS_LCD_TEXT_NAME,
     IDS_FLAGS_LCD_TEXT_DESCRIPTION,
     kOsDesktop,
     MULTI_VALUE_TYPE(kLCDTextChoices)
   },
-#ifndef USE_AURA
+#if defined(OS_ANDROID)

[piman, 2014/05/15 16:57:47]

Actually, we want this on mac too.

[Lei Zhang, 2014/05/20 02:38:21]

Are you going to do that in a different CL soon? As is, since
|supported_platforms| == kOsAndroid, this might as well just be inside a #if
defined(OS_ANDROID) block.

[piman, 2014/05/20 02:50:58]

Basic support just got added last week -
https://codereview.chromium.org/267073003

I'm not sure when Chris intends to add a flag, but I suppose we could do that
soon.

   {
     "delegated-renderer",
     IDS_FLAGS_DELEGATED_RENDERER_NAME,
     IDS_FLAGS_DELEGATED_RENDERER_DESCRIPTION,
     kOsAndroid,
     MULTI_VALUE_TYPE(kDelegatedRendererChoices)
   },
 #endif
   {
     "max-tiles-for-interest-area",
@@ skipping 1164 matching lines @@
 }
 
 const Experiment* GetExperiments(size_t* count) {
   *count = num_experiments;
   return experiments;
 }
 
 }  // namespace testing
 
 }  // namespace about_flags