Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Issue 2904583003: Support multiple URLs for latency testing (Closed)

Created:
3 years, 7 months ago by bsheedy
Modified:
3 years, 6 months ago
Reviewers:
klausw, mthiesse, Lei Lei
CC:
chromium-reviews, feature-vr-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Support multiple URLs for latency testing Adds support for testing multiple URLs per script run for automated VR latency testing. Allows us to get latency results from more realistic scenarios instead of just the synthetic flicker app without having to run the script and all the setup overhead that comes with it multiple times. Also fixes an issue caused by the recent swarming bot config change that resulted in the adb startup message appearing in the device name. BUG=708747 Review-Url: https://codereview.chromium.org/2904583003 Cr-Commit-Position: refs/heads/master@{#476058} Committed: https://chromium.googlesource.com/chromium/src/+/cfcb849246a5b77e9cac7ae92813f9b386f83b68

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add URL with no additional JS work #

Patch Set 3 : Address nits #

Patch Set 4 : Fix hanging issue during long tests #

Patch Set 5 : Fix adb startup message appearing in device name #

Unified diffs Side-by-side diffs Delta from patch set Stats (+156 lines, -55 lines) Patch
M chrome/test/vr/perf/latency/android_webvr_latency_test.py View 1 2 3 4 3 chunks +14 lines, -3 lines 0 comments Download
M chrome/test/vr/perf/latency/robot_arm.py View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/test/vr/perf/latency/run_latency_test.py View 3 chunks +7 lines, -8 lines 0 comments Download
M chrome/test/vr/perf/latency/webvr_latency_test.py View 1 2 3 4 chunks +131 lines, -44 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
bsheedy
+klausw for URL selection - can add more/change them around as desired +leilei for overall ...
3 years, 7 months ago (2017-05-24 00:56:50 UTC) #2
Lei Lei
lgtm https://codereview.chromium.org/2904583003/diff/1/chrome/test/vr/perf/latency/webvr_latency_test.py File chrome/test/vr/perf/latency/webvr_latency_test.py (right): https://codereview.chromium.org/2904583003/diff/1/chrome/test/vr/perf/latency/webvr_latency_test.py#newcode130 chrome/test/vr/perf/latency/webvr_latency_test.py:130: """Perform any platform-specific setup before each test.""" s/Perform/Performs ...
3 years, 7 months ago (2017-05-24 01:04:48 UTC) #3
bsheedy
Tested to work properly with the Chrome performance dashboard. +phajdan.jr for chrome/test OWNERS https://codereview.chromium.org/2904583003/diff/1/chrome/test/vr/perf/latency/webvr_latency_test.py File ...
3 years, 7 months ago (2017-05-25 17:46:23 UTC) #6
bsheedy
-phajdan.jr +mthiesse for new VR-specific OWNERS
3 years, 6 months ago (2017-05-31 21:51:20 UTC) #8
mthiesse
lgtm
3 years, 6 months ago (2017-05-31 22:03:13 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2904583003/80001
3 years, 6 months ago (2017-05-31 22:04:47 UTC) #12
commit-bot: I haz the power
3 years, 6 months ago (2017-05-31 22:19:10 UTC) #15
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/cfcb849246a5b77e9cac7ae92813...

Powered by Google App Engine
This is Rietveld 408576698