Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(483)

Issue 2904583002: Reporting: Add Feature to fieldtrial_testing_config.json (Closed)

Created:
3 years, 7 months ago by Julia Tuttle
Modified:
3 years, 6 months ago
Reviewers:
rkaplow
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Reporting: Add Feature to fieldtrial_testing_config.json BUG=676024, 704259 Review-Url: https://codereview.chromium.org/2904583002 Cr-Commit-Position: refs/heads/master@{#474434} Committed: https://chromium.googlesource.com/chromium/src/+/8ef9cbb441f237546060032abdbc7a04ba73cfc1

Patch Set 1 #

Total comments: 1

Patch Set 2 : Reporting -> ReportingAPI #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -0 lines) Patch
M testing/variations/fieldtrial_testing_config.json View 1 1 chunk +20 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (13 generated)
Julia Tuttle
PTAL, rkaplow.
3 years, 7 months ago (2017-05-23 17:31:35 UTC) #4
rkaplow
lgtm https://codereview.chromium.org/2904583002/diff/1/testing/variations/fieldtrial_testing_config.json File testing/variations/fieldtrial_testing_config.json (right): https://codereview.chromium.org/2904583002/diff/1/testing/variations/fieldtrial_testing_config.json#newcode2539 testing/variations/fieldtrial_testing_config.json:2539: "Reporting": [ kind of nit - I'd prefer ...
3 years, 6 months ago (2017-05-24 17:31:49 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2904583002/20001
3 years, 6 months ago (2017-05-24 20:34:08 UTC) #14
commit-bot: I haz the power
3 years, 6 months ago (2017-05-24 21:48:22 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/8ef9cbb441f237546060032abdbc...

Powered by Google App Engine
This is Rietveld 408576698