Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(358)

Issue 2904563004: [ServiceWorker] Fix ExtendableMessageEvent idl binding (Closed)

Created:
3 years, 7 months ago by leonhsl(Using Gerrit)
Modified:
3 years, 7 months ago
Reviewers:
falken, shimazu
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, kenjibaheux+watch_chromium.org, shimazu+serviceworker_chromium.org, serviceworker-reviews, blink-reviews-w3ctests_chromium.org, nhiroki, haraken, kinuko+serviceworker, blink-reviews, horo+watch_chromium.org, falken+watch_chromium.org, tzik
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[ServiceWorker] Fix ExtendableMessageEvent idl binding Spec: https://w3c.github.io/ServiceWorker/#extendablemessageevent-interface ExtendableMessageEventInit.ports should NOT allow null, ExtendableMessageEvent.ports should be empty array by default. BUG=702352, 702361 TEST=blink_tests external/wpt/service-workers/service-worker/ServiceWorkerGlobalScope/extendable-message-event-constructor.https.html Review-Url: https://codereview.chromium.org/2904563004 Cr-Commit-Position: refs/heads/master@{#474528} Committed: https://chromium.googlesource.com/chromium/src/+/2b468e6409c8077f9588eaadd33fa3c493bcaebf

Patch Set 1 #

Messages

Total messages: 14 (8 generated)
leonhsl(Using Gerrit)
PTAL, Thanks! # Locally confirmed corresponding wpt test PASS.
3 years, 7 months ago (2017-05-24 09:25:27 UTC) #4
falken
lgtm, great
3 years, 7 months ago (2017-05-25 00:34:40 UTC) #7
shimazu
lgtm2, thanks:)
3 years, 7 months ago (2017-05-25 02:13:22 UTC) #8
shimazu
On 2017/05/25 02:13:22, shimazu wrote: > lgtm2, thanks:) lgtm too.
3 years, 7 months ago (2017-05-25 02:13:44 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2904563004/1
3 years, 7 months ago (2017-05-25 02:19:38 UTC) #11
commit-bot: I haz the power
3 years, 7 months ago (2017-05-25 02:25:17 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2b468e6409c8077f9588eaadd33f...

Powered by Google App Engine
This is Rietveld 408576698