Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1751)

Unified Diff: apps/ui/views/BUILD.gn

Issue 2904443004: Allow generation of a chromium outdirs when enable_extensions=false (Closed)
Patch Set: Rebase and address comment in src/BUILD.gn Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« apps/BUILD.gn ('K') | « apps/BUILD.gn ('k') | chrome/browser/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: apps/ui/views/BUILD.gn
diff --git a/apps/ui/views/BUILD.gn b/apps/ui/views/BUILD.gn
index bd7d9076500e97015631244ce35cb5538de2380b..cd33ee32fdcc766058f97c7fbceb917226bee366 100644
--- a/apps/ui/views/BUILD.gn
+++ b/apps/ui/views/BUILD.gn
@@ -5,8 +5,6 @@
import("//build/config/ui.gni")
import("//extensions/features/features.gni")
-assert(enable_extensions)
-
source_set("views") {
michaelpg 2017/06/08 22:54:41 this shouldn't be built if (!enable_extensions) ca
hugoh_UTC2 2017/06/09 09:25:42 You're right. Problem was that chrome/browser/ui/B
sources = [
"app_window_frame_view.cc",
@@ -16,11 +14,16 @@ source_set("views") {
deps = [
"//cc/paint",
"//chrome/app/theme:theme_resources",
- "//extensions/browser/app_window",
- "//extensions/common",
"//skia",
"//ui/gfx",
"//ui/strings",
"//ui/views",
]
+
+ if (enable_extensions) {
+ deps += [
+ "//extensions/browser/app_window",
+ "//extensions/common",
+ ]
+ }
}
« apps/BUILD.gn ('K') | « apps/BUILD.gn ('k') | chrome/browser/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698