Allow generation of a chromium outdirs when enable_extensions=false

extensions/browser/BUILD.gn

Index: extensions/browser/BUILD.gn
diff --git a/extensions/browser/BUILD.gn b/extensions/browser/BUILD.gn
index b6d2d4f88b0d4783884294ea207c678d85b046c7..476b8aae53f7394ed680ef3c5f34a4f89f53f23a 100644
--- a/extensions/browser/BUILD.gn
+++ b/extensions/browser/BUILD.gn
@@ -6,19 +6,18 @@ import("//build/config/features.gni")
 import("//extensions/features/features.gni")
 
 group("browser") {
-  public_deps = [
-    "//extensions/browser:browser_context_keyed_service_factories",
-    "//extensions/browser:browser_sources",
-    "//extensions/browser/api:api_registration",
-  ]
-
   if (enable_extensions) {
     # Includes all API implementations and the ExtensionsApiClient
     # interface. Moving an API from src/chrome to src/extensions implies
     # it can be cleanly disabled with enable_extensions=false.
     # TODO: Eventually the entire extensions module should not be built
     # when enable_extensions=false.
-    public_deps += [ "//extensions/browser/api" ]
+    public_deps = [

[Dirk Pranke, 2017/05/23 20:00:11]

How feasible is it to make it so that nothing under //extensions is getting
included if enable_extensions is false?

i.e., can we get to a point where all //extensions/* BUILD files have
assert(enable_extensions) at the top?

+      "//extensions/browser:browser_context_keyed_service_factories",
+      "//extensions/browser:browser_sources",
+      "//extensions/browser/api",
+      "//extensions/browser/api:api_registration",
+    ]
   }
 }
 
@@ -58,14 +57,19 @@ source_set("browser_sources") {
     "//content/public/browser",
     "//content/public/common",
     "//crypto:platform",
-    "//extensions/common",
-    "//extensions/common/api",
-    "//extensions/features",
-    "//extensions/strings",
     "//google_apis",
     "//ui/display",
   ]
 
+  if (enable_extensions) {
+    deps += [
+      "//extensions/common",
+      "//extensions/common/api",
+      "//extensions/features",
+      "//extensions/strings",
+    ]
+  }
+
   configs += [
     "//build/config:precompiled_headers",
 
@@ -356,14 +360,19 @@ source_set("browser_tests") {
     "//device/bluetooth:mocks",
     "//device/hid:mocks",
     "//device/usb:test_support",
-    "//extensions:test_support",
-    "//extensions/common",
-    "//extensions/common/api",
-    "//extensions/shell:app_shell_lib",
-    "//extensions/shell:browser_tests",
     "//net:test_support",
   ]
 
+  if (enable_extensions) {
+    deps += [
+      "//extensions:test_support",
+      "//extensions/common",
+      "//extensions/common/api",
+      "//extensions/shell:app_shell_lib",
+      "//extensions/shell:browser_tests",
+    ]
+  }
+
   if (is_mac) {
     # Needed for App Shell.app's Helper.
     deps += [ "//extensions/shell:app_shell" ]
@@ -384,10 +393,15 @@ source_set("test_support") {
 
   deps = [
     "//base",
-    "//extensions/browser",
-    "//extensions/common",
     "//testing/gtest",
   ]
+
+  if (enable_extensions) {
+    deps += [
+      "//extensions/browser",
+      "//extensions/common",
+    ]
+  }
 }
 
 source_set("unit_tests") {
@@ -496,11 +510,6 @@ source_set("unit_tests") {
     "//content/test:test_support",
     "//device/bluetooth:mocks",
     "//device/power_save_blocker",
-    "//extensions:extensions_browser_resources",
-    "//extensions:test_support",
-    "//extensions/common",
-    "//extensions/common/api",
-    "//extensions/features",
     "//ipc:test_support",
     "//net:test_support",
     "//storage/browser:test_support",
@@ -508,6 +517,16 @@ source_set("unit_tests") {
     "//third_party/zlib/google:zip",
   ]
 
+  if (enable_extensions) {
+    deps += [
+      "//extensions:extensions_browser_resources",
+      "//extensions:test_support",
+      "//extensions/common",
+      "//extensions/common/api",
+      "//extensions/features",
+    ]
+  }
+
   if (is_chromeos) {
     sources += [
       "api/audio/audio_device_id_calculator_unittest.cc",