Use only LayoutText::AbsoluteQuadsForRange() in VisibleUnit::ComputeTextBounds()

Use only LayoutText::AbsoluteQuadsForRange() in VisibleUnit::ComputeTextBounds()

There are LayoutText::AbsoluteRectsForRange() and AbsoluteQuadsForRange().
The former collects IntRect and the later collects FloatQuad
 through very similar algorithm.

The only difference between two is the former converts from FloatQuad,
 which is just the later collects, to IntRect with EnclosingBoundingBox().
Since we collects rects and unify all of them, it is OK to refactor
 from "UnifyIntRect(float_quads.Map(f => f.EnclosingBoundingBox()))"
 to "UnifyFloatRect(float_quads).EnclosingBoundingBox())".

BUG=

Review-Url: https://codereview.chromium.org/2904433002
Cr-Commit-Position: refs/heads/master@{#473840}
Committed: https://chromium.googlesource.com/chromium/src/+/e9e8ed890a60d669fabdcb3ef3bbafe5eeeb74f3

[yoichio, 2017-05-23 06:18:56]

The CQ bit was checked by yoichio@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-23 06:19:06]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yoichio, 2017-05-23 07:47:56]

Description was changed from

==========
Use only AbsoluteQuadsForRange in VisibleUnit::ComputeTextBounds

BUG=
==========

to

==========
Use only LayoutText::AbsoluteQuadsForRange() in VisibleUnit::ComputeTextBounds()

There are LayoutText::AbsoluteRectsForRange() and AbsoluteQuadsForRange()
The former collects IntRect and the later collects FloatQuad
 through very similar algorithm.

The only difference between two is the former converts from FloatQuad,
 which is just the later collects, to IntRect with EnclosingBoundingBox().
Since we collects rects and unify all of them, it is OK to refactor
 from "UnifyIntRect(float_quads.Map(f => f.EnclosingBoundingBox()))"
 to "UnifyFloatRect(float_quads).EnclosingBoundingBox())".

BUG=
==========

[yoichio, 2017-05-23 07:47:57]

yoichio@chromium.org changed reviewers:
+ yosin@chromium.org

[yoichio, 2017-05-23 07:48:29]

Description was changed from

==========
Use only LayoutText::AbsoluteQuadsForRange() in VisibleUnit::ComputeTextBounds()

There are LayoutText::AbsoluteRectsForRange() and AbsoluteQuadsForRange()
The former collects IntRect and the later collects FloatQuad
 through very similar algorithm.

The only difference between two is the former converts from FloatQuad,
 which is just the later collects, to IntRect with EnclosingBoundingBox().
Since we collects rects and unify all of them, it is OK to refactor
 from "UnifyIntRect(float_quads.Map(f => f.EnclosingBoundingBox()))"
 to "UnifyFloatRect(float_quads).EnclosingBoundingBox())".

BUG=
==========

to

==========
Use only LayoutText::AbsoluteQuadsForRange() in VisibleUnit::ComputeTextBounds()

There are LayoutText::AbsoluteRectsForRange() and AbsoluteQuadsForRange().
The former collects IntRect and the later collects FloatQuad
 through very similar algorithm.

The only difference between two is the former converts from FloatQuad,
 which is just the later collects, to IntRect with EnclosingBoundingBox().
Since we collects rects and unify all of them, it is OK to refactor
 from "UnifyIntRect(float_quads.Map(f => f.EnclosingBoundingBox()))"
 to "UnifyFloatRect(float_quads).EnclosingBoundingBox())".

BUG=
==========

[commit-bot: I haz the power, 2017-05-23 07:49:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-23 07:49:36]

Dry run: This issue passed the CQ dry run.

[yosin_UTC9, 2017-05-23 08:35:29]

lgtm

Cool!

[yosin_UTC9, 2017-05-23 08:35:31]

The CQ bit was checked by yosin@chromium.org

[commit-bot: I haz the power, 2017-05-23 08:35:45]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-23 08:40:28]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1495528531451150, "parent_rev":
"ddc5e16ef9191ecf5f74c039ed8cebaf9390765b", "commit_rev":
"e9e8ed890a60d669fabdcb3ef3bbafe5eeeb74f3"}

[commit-bot: I haz the power, 2017-05-23 08:40:42]

Description was changed from

==========
Use only LayoutText::AbsoluteQuadsForRange() in VisibleUnit::ComputeTextBounds()

There are LayoutText::AbsoluteRectsForRange() and AbsoluteQuadsForRange().
The former collects IntRect and the later collects FloatQuad
 through very similar algorithm.

The only difference between two is the former converts from FloatQuad,
 which is just the later collects, to IntRect with EnclosingBoundingBox().
Since we collects rects and unify all of them, it is OK to refactor
 from "UnifyIntRect(float_quads.Map(f => f.EnclosingBoundingBox()))"
 to "UnifyFloatRect(float_quads).EnclosingBoundingBox())".

BUG=
==========

to

==========
Use only LayoutText::AbsoluteQuadsForRange() in VisibleUnit::ComputeTextBounds()

There are LayoutText::AbsoluteRectsForRange() and AbsoluteQuadsForRange().
The former collects IntRect and the later collects FloatQuad
 through very similar algorithm.

The only difference between two is the former converts from FloatQuad,
 which is just the later collects, to IntRect with EnclosingBoundingBox().
Since we collects rects and unify all of them, it is OK to refactor
 from "UnifyIntRect(float_quads.Map(f => f.EnclosingBoundingBox()))"
 to "UnifyFloatRect(float_quads).EnclosingBoundingBox())".

BUG=

Review-Url: https://codereview.chromium.org/2904433002
Cr-Commit-Position: refs/heads/master@{#473840}
Committed:
https://chromium.googlesource.com/chromium/src/+/e9e8ed890a60d669fabdcb3ef3bb...
==========

[commit-bot: I haz the power, 2017-05-23 08:40:43]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e9e8ed890a60d669fabdcb3ef3bb...