Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Unified Diff: third_party/WebKit/Source/core/css/ComputedStyleExtraFields.json5

Issue 2904403002: Generate methods for TextEmphasis properties in ComputedStyleBase. (Closed)
Patch Set: Rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/ComputedStyleExtraFields.json5
diff --git a/third_party/WebKit/Source/core/css/ComputedStyleExtraFields.json5 b/third_party/WebKit/Source/core/css/ComputedStyleExtraFields.json5
index 0c8a3863799c92c4baa97250fe71fb8059dc8814..9eb6b4e3efe7a9837f2c363a7f1bd46efb7d3f55 100644
--- a/third_party/WebKit/Source/core/css/ComputedStyleExtraFields.json5
+++ b/third_party/WebKit/Source/core/css/ComputedStyleExtraFields.json5
@@ -417,13 +417,14 @@
field_size: 1,
field_group: "rare-inherited",
},
+ // TODO(shend): Put this in text-emphasis-style in CSSProperties.json5.
meade_UTC10 2017/05/30 03:51:33 What's blocking doing it now? Just keeping the CL
{
name: "TextEmphasisFill",
inherited: true,
- field_template: "storage_only",
+ field_template: "keyword",
type_name: "TextEmphasisFill",
- default_value: "TextEmphasisFill::kFilled",
- field_size: 1,
+ default_value: "filled",
+ keywords: ["filled", "open"],
field_group: "rare-inherited",
},
{
@@ -436,15 +437,6 @@
field_group: "rare-inherited",
},
{
- name: "TextEmphasisPosition",
- inherited: true,
- field_template: "storage_only",
- type_name: "TextEmphasisPosition",
- default_value: "TextEmphasisPosition::kOver",
- field_size: 1,
- field_group: "rare-inherited",
- },
- {
name: "TextIndentLine",
inherited: true,
field_template: "storage_only",
@@ -529,7 +521,7 @@
{
name: "TextEmphasisCustomMark",
inherited: true,
- field_template: "storage_only",
+ field_template: "external",
type_name: "AtomicString",
include_paths: ["platform/wtf/text/AtomicString.h"],
default_value: "AtomicString()",
« no previous file with comments | « third_party/WebKit/Source/core/css/CSSProperties.json5 ('k') | third_party/WebKit/Source/core/style/ComputedStyle.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698