Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 2904353002: CHECK XPS initialization succeeds on Windows. (Closed)

Created:
3 years, 6 months ago by Lei Zhang
Modified:
3 years, 6 months ago
Reviewers:
rbpotter
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

CHECK XPS initialization succeeds on Windows. It should on Windows 7 and beyond. Review-Url: https://codereview.chromium.org/2904353002 Cr-Commit-Position: refs/heads/master@{#475976} Committed: https://chromium.googlesource.com/chromium/src/+/03dc326e1e32f3262322d1366cd94fbf99826ab5

Patch Set 1 #

Patch Set 2 : MakeUnique instead #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -29 lines) Patch
M chrome/service/cloud_print/print_system_win.cc View 2 chunks +12 lines, -15 lines 0 comments Download
M printing/backend/print_backend_win.cc View 1 4 chunks +18 lines, -14 lines 0 comments Download
M printing/backend/win_helper.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (12 generated)
Lei Zhang
3 years, 6 months ago (2017-05-31 16:22:56 UTC) #10
rbpotter
lgtm
3 years, 6 months ago (2017-05-31 17:52:57 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2904353002/20001
3 years, 6 months ago (2017-05-31 17:55:55 UTC) #13
commit-bot: I haz the power
3 years, 6 months ago (2017-05-31 19:12:28 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/03dc326e1e32f3262322d1366cd9...

Powered by Google App Engine
This is Rietveld 408576698