Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issue 2904293002: Omnibox - Clipboard Provider - Record Number of Times Suggestion Offered (Closed)

Created:
3 years, 7 months ago by Mark P
Modified:
3 years, 6 months ago
Reviewers:
jif, Ilya Sherman
CC:
chromium-reviews, jdonnelly+watch_chromium.org, asvitkine+watch_chromium.org, dcheng
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Omnibox - Clipboard Provider - Record Number of Times Suggestion Offered BUG=718187 Review-Url: https://codereview.chromium.org/2904293002 Cr-Commit-Position: refs/heads/master@{#476453} Committed: https://chromium.googlesource.com/chromium/src/+/ea5016a9460ba717ca21893de068f4d2a3f43746

Patch Set 1 #

Patch Set 2 : cl format #

Patch Set 3 : new version, between managements of 1s and 0s #

Patch Set 4 : comment cleanup #

Total comments: 8

Patch Set 5 : initial properly #

Patch Set 6 : isherman's comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -5 lines) Patch
M components/omnibox/browser/clipboard_url_provider.h View 1 2 chunks +6 lines, -0 lines 0 comments Download
M components/omnibox/browser/clipboard_url_provider.cc View 1 2 3 4 5 5 chunks +39 lines, -5 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 3 4 5 1 chunk +27 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
Mark P
Hey folks, Please take a look a when you get a chance: - jif@ code, ...
3 years, 6 months ago (2017-05-30 23:31:14 UTC) #2
jif
https://codereview.chromium.org/2904293002/diff/60001/components/omnibox/browser/clipboard_url_provider.cc File components/omnibox/browser/clipboard_url_provider.cc (right): https://codereview.chromium.org/2904293002/diff/60001/components/omnibox/browser/clipboard_url_provider.cc#newcode27 components/omnibox/browser/clipboard_url_provider.cc:27: history_url_provider_(history_url_provider) { add: current_url_suggested_times_(0) https://codereview.chromium.org/2904293002/diff/60001/components/omnibox/browser/clipboard_url_provider.cc#newcode100 components/omnibox/browser/clipboard_url_provider.cc:100: void ClipboardURLProvider::AddProviderInfo(ProvidersInfo* provider_info) ...
3 years, 6 months ago (2017-05-31 09:27:48 UTC) #3
Ilya Sherman
Metrics LGTM % nits: https://codereview.chromium.org/2904293002/diff/60001/components/omnibox/browser/clipboard_url_provider.cc File components/omnibox/browser/clipboard_url_provider.cc (right): https://codereview.chromium.org/2904293002/diff/60001/components/omnibox/browser/clipboard_url_provider.cc#newcode80 components/omnibox/browser/clipboard_url_provider.cc:80: current_url_suggested_times_, 20); nit: Is this ...
3 years, 6 months ago (2017-05-31 23:40:23 UTC) #4
Mark P
https://codereview.chromium.org/2904293002/diff/60001/components/omnibox/browser/clipboard_url_provider.cc File components/omnibox/browser/clipboard_url_provider.cc (right): https://codereview.chromium.org/2904293002/diff/60001/components/omnibox/browser/clipboard_url_provider.cc#newcode27 components/omnibox/browser/clipboard_url_provider.cc:27: history_url_provider_(history_url_provider) { On 2017/05/31 09:27:47, jif wrote: > add: ...
3 years, 6 months ago (2017-05-31 23:41:52 UTC) #5
Mark P
Hey folks, please take another look if you want. thanks, mark https://codereview.chromium.org/2904293002/diff/60001/components/omnibox/browser/clipboard_url_provider.cc File components/omnibox/browser/clipboard_url_provider.cc (right): ...
3 years, 6 months ago (2017-06-01 04:16:33 UTC) #6
jif
lgtm
3 years, 6 months ago (2017-06-01 06:51:13 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2904293002/100001
3 years, 6 months ago (2017-06-01 20:38:37 UTC) #10
commit-bot: I haz the power
3 years, 6 months ago (2017-06-01 22:20:51 UTC) #13
Message was sent while issue was closed.
Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/ea5016a9460ba717ca21893de068...

Powered by Google App Engine
This is Rietveld 408576698