Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issue 2904253002: Remove SequencedWorkerPool::PostWorkerTask(). (Closed)

Created:
3 years, 6 months ago by fdoray
Modified:
3 years, 6 months ago
Reviewers:
gab
CC:
chromium-reviews, danakj+watch_chromium.org, vmpstr+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove SequencedWorkerPool::PostWorkerTask(). BUG=667892 Review-Url: https://codereview.chromium.org/2904253002 Cr-Commit-Position: refs/heads/master@{#475166} Committed: https://chromium.googlesource.com/chromium/src/+/03aa6d03b458938440a5910baae25da66718c5c2

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : wip #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -59 lines) Patch
M base/threading/sequenced_worker_pool.h View 2 chunks +1 line, -24 lines 0 comments Download
M base/threading/sequenced_worker_pool.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M base/threading/sequenced_worker_pool_unittest.cc View 10 chunks +27 lines, -28 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 20 (13 generated)
fdoray
PTAL
3 years, 6 months ago (2017-05-26 20:25:39 UTC) #9
gab
W00T!
3 years, 6 months ago (2017-05-26 21:00:47 UTC) #10
gab
On 2017/05/26 21:00:47, gab wrote: > W00T! OOps, lgtm too ;)!
3 years, 6 months ago (2017-05-26 21:00:58 UTC) #11
commit-bot: I haz the power
This CL has an open dependency (Issue 2906753004 Patch 40001). Please resolve the dependency and ...
3 years, 6 months ago (2017-05-26 21:02:38 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2904253002/60001
3 years, 6 months ago (2017-05-26 22:36:40 UTC) #16
commit-bot: I haz the power
Committed patchset #4 (id:60001) as https://chromium.googlesource.com/chromium/src/+/03aa6d03b458938440a5910baae25da66718c5c2
3 years, 6 months ago (2017-05-26 22:41:32 UTC) #19
sdefresne
3 years, 6 months ago (2017-05-30 11:17:20 UTC) #20
Message was sent while issue was closed.
A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/2912073002/ by sdefresne@chromium.org.

The reason for reverting is: Reverting as this prevent reverting a change
breaking iOS bots, see org/p/chromium/issues/detail?id=727611..

Powered by Google App Engine
This is Rietveld 408576698