pkg/kernel/lib/transformations/closure_conversion.dart - Issue 2904203003: Don't recreate CoreTypes in transformers. Pass it in.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/kernel/lib/transformations/closure_conversion.dart

Issue 2904203003: Don't recreate CoreTypes in transformers. Pass it in. (Closed)

Patch Set: Don't create CoreTypes in createOutlines() on InputError. Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/kernel/lib/transformations/closure_conversion.dart

diff --git a/pkg/kernel/lib/transformations/closure_conversion.dart b/pkg/kernel/lib/transformations/closure_conversion.dart

index 44ae82812eac613046877ca9b487025b6a6e5c44..5588e8006aeab2b48cc191c60d59648e4845b449 100644

--- a/pkg/kernel/lib/transformations/closure_conversion.dart

+++ b/pkg/kernel/lib/transformations/closure_conversion.dart

@@ -15,11 +15,10 @@ import 'closure/info.dart' show ClosureInfo;

import 'closure/invalidate_closures.dart';

import 'closure/mock.dart' show mockUpContext;

-Program transformProgram(Program program) {

+Program transformProgram(CoreTypes coreTypes, Program program) {

var info = new ClosureInfo();

info.visitProgram(program);

- CoreTypes coreTypes = new CoreTypes(program);

Class contextClass = mockUpContext(coreTypes, program);

var convert = new ClosureConverter(coreTypes, info, contextClass);

program = convert.visitProgram(program);

« no previous file with comments | « pkg/kernel/lib/target/vmreify.dart ('k') | pkg/kernel/lib/transformations/continuation.dart » ('j') | no next file with comments »