Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Unified Diff: pkg/kernel/lib/target/vmreify.dart

Issue 2904203003: Don't recreate CoreTypes in transformers. Pass it in. (Closed)
Patch Set: Don't create CoreTypes in createOutlines() on InputError. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/kernel/lib/target/vmcc.dart ('k') | pkg/kernel/lib/transformations/closure_conversion.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/kernel/lib/target/vmreify.dart
diff --git a/pkg/kernel/lib/target/vmreify.dart b/pkg/kernel/lib/target/vmreify.dart
index 1d0fe0a903400036628025bf4d6aaeb74fa852a0..17d2d52467c6ebb12c87faa159f5e7c9a4989c6f 100644
--- a/pkg/kernel/lib/target/vmreify.dart
+++ b/pkg/kernel/lib/target/vmreify.dart
@@ -4,9 +4,9 @@
library kernel.target.vmreify;
import '../ast.dart' show Program;
+import '../core_types.dart' show CoreTypes;
import '../transformations/generic_types_reification.dart' as reify
show transformProgram;
-
import 'targets.dart' show TargetFlags;
import 'vmcc.dart' as vmcc_target;
@@ -27,10 +27,10 @@ class VmGenericTypesReifiedTarget extends vmcc_target.VmClosureConvertedTarget {
}
@override
- void performGlobalTransformations(Program program) {
- super.performGlobalTransformations(program);
+ void performGlobalTransformations(CoreTypes coreTypes, Program program) {
+ super.performGlobalTransformations(coreTypes, program);
// TODO(dmitryas) this transformation should be made modular
- reify.transformProgram(program);
+ reify.transformProgram(coreTypes, program);
}
// Disable tree shaking for Generic Types Reification. There are some runtime
@@ -39,7 +39,7 @@ class VmGenericTypesReifiedTarget extends vmcc_target.VmClosureConvertedTarget {
// the transformation.
// TODO(dmitryas): remove this when the libraries are in dart:_internal
@override
- void performTreeShaking(Program program) {}
+ void performTreeShaking(CoreTypes coreTypes, Program program) {}
// Here we disable Erasure pass of VmTarget class. The information deleted by
// the Erasure pass is required for Generic Type Reification. Also, reify
« no previous file with comments | « pkg/kernel/lib/target/vmcc.dart ('k') | pkg/kernel/lib/transformations/closure_conversion.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698