Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Unified Diff: pkg/kernel/bin/transform.dart

Issue 2904203003: Don't recreate CoreTypes in transformers. Pass it in. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/kernel/bin/transform.dart
diff --git a/pkg/kernel/bin/transform.dart b/pkg/kernel/bin/transform.dart
index 1207e418680cc92422ac848f2932c06d5fc3f198..eb083d27d5ea075f7f7b07f5f952ed5e72b5d8f6 100755
--- a/pkg/kernel/bin/transform.dart
+++ b/pkg/kernel/bin/transform.dart
@@ -7,6 +7,7 @@ import 'dart:async';
import 'dart:io';
import 'package:args/args.dart';
+import 'package:kernel/core_types.dart';
import 'package:kernel/kernel.dart';
import 'package:kernel/transformations/closure_conversion.dart' as closures;
import 'package:kernel/transformations/continuation.dart' as cont;
@@ -74,22 +75,23 @@ Future<CompilerOutcome> runTransformation(List<String> arguments) async {
parseProgramRoots(embedderEntryPointManifests);
var program = loadProgramFromBinary(input);
+ var coreTypes = new CoreTypes(program);
switch (options['transformation']) {
case 'continuation':
- program = cont.transformProgram(program);
+ program = cont.transformProgram(coreTypes, program);
break;
case 'resolve-mixins':
- program = mix.transformProgram(program);
+ program = mix.transformProgram(coreTypes, program);
break;
case 'closures':
- program = closures.transformProgram(program);
+ program = closures.transformProgram(coreTypes, program);
break;
case 'treeshake':
- program =
- treeshaker.transformProgram(program, programRoots: programRoots);
+ program = treeshaker.transformProgram(coreTypes, program,
+ programRoots: programRoots);
break;
case 'methodcall':
- program = method_call.transformProgram(program);
+ program = method_call.transformProgram(coreTypes, program);
break;
case 'empty':
program = empty.transformProgram(program);

Powered by Google App Engine
This is Rietveld 408576698