Chromium Code Reviews Chromium Code Reviews
Issue 2904203003:
Don't recreate CoreTypes in transformers. Pass it in. (Closed)
| Index: pkg/front_end/test/fasta/kompile.status |
| diff --git a/pkg/front_end/test/fasta/kompile.status b/pkg/front_end/test/fasta/kompile.status |
| index 780a1e39e5aee18f43dfb8b7cd52dfbc5825871e..dc7b7b3730914012f207e26587a37fb0e8ffc1e2 100644 |
| --- a/pkg/front_end/test/fasta/kompile.status |
| +++ b/pkg/front_end/test/fasta/kompile.status |
| @@ -12,13 +12,15 @@ accessors: Crash |
| argument: Crash |
| arithmetic: Crash |
| async_function: Crash |
| -await: Fail |
| +await: Crash |
|
Paul Berry
2017/05/26 19:04:54
Why do all these tests crash now? This seems like
scheglov
2017/05/26 19:17:58
We need to create CoreTypes in AnalyzerLoader too.
|
| bad_store: Crash |
| call: Crash |
| +cascade: Crash |
| +casts: Crash |
| classes: Crash |
| closure: Crash |
| covariant_generic: Crash |
| -cycles: Fail |
| +cycles: Crash |
| default_values: Crash |
| escape: Crash |
| expressions: Crash |
| @@ -28,12 +30,14 @@ fibonacci: Crash |
| for_in_scope: Crash |
| function_in_field: Crash |
| function_type_is_check: Crash |
| -function_type_recovery: Fail |
| +function_type_recovery: Crash |
| functions: Crash |
| +hello: Crash |
| implicit_scope_test: Crash |
| implicit_this: Crash |
| -invocations: Fail |
| -map: Fail |
| +invocations: Crash |
| +literals: Crash |
| +map: Crash |
| micro: Crash |
| mixin: Crash |
| named_parameters: Crash |
| @@ -41,21 +45,23 @@ null_aware: Crash |
| operators: Crash |
| optional: Crash |
| override: Crash |
| +platform: Crash |
| prefer_baseclass: Crash |
| -redirecting_constructor: Fail |
| +redirecting_constructor: Crash |
| redirecting_factory: Crash |
| -statements: Fail |
| +statements: Crash |
| static_setter: Crash |
| store_load: Crash |
| stringliteral: Crash |
| super_rasta_copy: Crash |
| top_level_accessors: Crash |
| -type_variable_as_super: Fail |
| +type_variable_as_super: Crash |
| typedef: Crash |
| uninitialized_fields: Crash |
| unused_methods: Crash |
| void-methods: Crash |
| +inference/assign_local: Crash |
| inference/async_closure_return_type_flatten: Crash |
| inference/async_closure_return_type_future: Crash |
| inference/async_closure_return_type_future_or: Crash |
| @@ -81,10 +87,11 @@ inference/bottom: Crash |
| inference/bottom_in_closure: Crash |
| inference/circular_reference_via_closures: Crash |
| inference/circular_reference_via_closures_initializer_types: Crash |
| +inference/coerce_bottom_and_null_types: Crash |
| inference/conditional_lub: Crash |
| -inference/conflicts_can_happen2: Crash |
| inference/conflicts_can_happen: Crash |
| -inference/constructors_downwards_with_constraint: Fail |
| +inference/conflicts_can_happen2: Crash |
| +inference/constructors_downwards_with_constraint: Crash |
| inference/constructors_infer_from_arguments: Crash |
| inference/constructors_infer_from_arguments_argument_not_assignable: Crash |
| inference/constructors_infer_from_arguments_const: Crash |
| @@ -99,15 +106,17 @@ inference/constructors_infer_from_arguments_redirecting_factory: Crash |
| inference/constructors_infer_from_arguments_redirecting_factory_to_factory: Crash |
| inference/constructors_inference_f_bounded: Crash |
| inference/constructors_reverse_type_parameters: Crash |
| -inference/constructors_too_many_positional_arguments: Fail |
| +inference/constructors_too_many_positional_arguments: Crash |
| inference/do_not_infer_overridden_fields_that_explicitly_say_dynamic_infer: Crash |
| inference/dont_infer_field_type_when_initializer_is_null: Crash |
| inference/dont_infer_type_on_dynamic: Crash |
| +inference/dont_infer_type_when_initializer_is_null: Crash |
| inference/downward_inference_fixes_no_upwards_errors: Crash |
| inference/downward_inference_miscellaneous: Crash |
| inference/downwards_inference_annotations: Crash |
| +inference/downwards_inference_assignment_statements: Crash |
| inference/downwards_inference_async_await: Crash |
| -inference/downwards_inference_for_each: Fail |
| +inference/downwards_inference_for_each: Crash |
| inference/downwards_inference_initializing_formal_default_formal: Crash |
| inference/downwards_inference_inside_top_level: Crash |
| inference/downwards_inference_on_constructor_arguments_infer_downwards: Crash |
| @@ -121,7 +130,7 @@ inference/downwards_inference_on_instance_creations_infer_downwards: Crash |
| inference/downwards_inference_on_list_literals_infer_downwards: Crash |
| inference/downwards_inference_on_list_literals_infer_if_value_types_match_context: Crash |
| inference/downwards_inference_on_map_literals: Crash |
| -inference/downwards_inference_yield_yield_star: Fail |
| +inference/downwards_inference_yield_yield_star: Crash |
| inference/field_refers_to_static_getter: Crash |
| inference/field_refers_to_top_level_getter: Crash |
| inference/future_or_subtyping: Crash |
| @@ -149,9 +158,9 @@ inference/future_union_downwards: Crash |
| inference/future_union_downwards_2: Crash |
| inference/future_union_downwards_3: Crash |
| inference/future_union_downwards_4: Crash |
| -inference/future_union_downwards_generic_method_with_future_return: Fail |
| +inference/future_union_downwards_generic_method_with_future_return: Crash |
| inference/future_union_downwards_generic_method_with_generic_return: Crash |
| -inference/future_union_upwards_generic_methods: Fail |
| +inference/future_union_upwards_generic_methods: Crash |
| inference/generic_functions_return_typedef: Crash |
| inference/generic_methods_basic_downward_inference: Crash |
| inference/generic_methods_correctly_recognize_generic_upper_bound: Crash |
| @@ -160,12 +169,12 @@ inference/generic_methods_do_not_infer_invalid_override_of_generic_method: Crash |
| inference/generic_methods_downwards_inference_affects_arguments: Crash |
| inference/generic_methods_downwards_inference_fold: Crash |
| inference/generic_methods_handle_override_of_non_generic_with_generic: Crash |
| -inference/generic_methods_infer_generic_function_parameter_type2: Crash |
| inference/generic_methods_infer_generic_function_parameter_type: Crash |
| +inference/generic_methods_infer_generic_function_parameter_type2: Crash |
| inference/generic_methods_infer_generic_function_return_type: Crash |
| inference/generic_methods_infer_generic_instantiation: Crash |
| inference/generic_methods_infer_generic_method_type: Crash |
| -inference/generic_methods_infer_js_builtin: Fail |
| +inference/generic_methods_infer_js_builtin: Crash |
| inference/generic_methods_inference_error: Crash |
| inference/generic_methods_iterable_and_future: Crash |
| inference/generic_methods_nested_generic_instantiation: Crash |
| @@ -186,19 +195,19 @@ inference/infer_consts_transitively_2_b: Crash |
| inference/infer_consts_transitively_b: Crash |
| inference/infer_correctly_on_multiple_variables_declared_together: Crash |
| inference/infer_from_complex_expressions_if_outer_most_value_is_precise: Crash |
| -inference/infer_from_rhs_only_if_it_wont_conflict_with_overridden_fields2: Crash |
| inference/infer_from_rhs_only_if_it_wont_conflict_with_overridden_fields: Crash |
| +inference/infer_from_rhs_only_if_it_wont_conflict_with_overridden_fields2: Crash |
| +inference/infer_from_variables_in_cycle_libs_when_flag_is_on: Crash |
| inference/infer_from_variables_in_cycle_libs_when_flag_is_on2: Crash |
| inference/infer_from_variables_in_cycle_libs_when_flag_is_on2_a: Crash |
| -inference/infer_from_variables_in_cycle_libs_when_flag_is_on: Crash |
| inference/infer_from_variables_in_cycle_libs_when_flag_is_on_a: Crash |
| +inference/infer_from_variables_in_non_cycle_imports_with_flag: Crash |
| inference/infer_from_variables_in_non_cycle_imports_with_flag2: Crash |
| inference/infer_from_variables_in_non_cycle_imports_with_flag2_a: Crash |
| -inference/infer_from_variables_in_non_cycle_imports_with_flag: Crash |
| inference/infer_from_variables_in_non_cycle_imports_with_flag_a: Crash |
| inference/infer_generic_method_type_named: Crash |
| -inference/infer_generic_method_type_positional2: Crash |
| inference/infer_generic_method_type_positional: Crash |
| +inference/infer_generic_method_type_positional2: Crash |
| inference/infer_generic_method_type_required: Crash |
| inference/infer_list_literal_nested_in_map_literal: Crash |
| inference/infer_local_function_return_type: Crash |
| @@ -207,10 +216,10 @@ inference/infer_parameter_type_setter_from_setter: Crash |
| inference/infer_prefix_expression: Crash |
| inference/infer_prefix_expression_custom: Crash |
| inference/infer_return_of_statement_lambda: Crash |
| +inference/infer_statics_transitively: Crash |
| inference/infer_statics_transitively2: Crash |
| inference/infer_statics_transitively3: Crash |
| inference/infer_statics_transitively3_a: Crash |
| -inference/infer_statics_transitively: Crash |
| inference/infer_statics_transitively_2_a: Crash |
| inference/infer_statics_transitively_a: Crash |
| inference/infer_statics_transitively_b: Crash |
| @@ -219,9 +228,12 @@ inference/infer_statics_with_method_invocations_a: Crash |
| inference/infer_throw: Crash |
| inference/infer_type_on_overridden_fields2: Crash |
| inference/infer_type_on_overridden_fields4: Crash |
| +inference/infer_type_on_var: Crash |
| +inference/infer_type_on_var2: Crash |
| inference/infer_type_on_var_from_field: Crash |
| inference/infer_type_on_var_from_top_level: Crash |
| -inference/infer_type_regardless_of_declaration_order_or_cycles: Fail |
| +inference/infer_type_regardless_of_declaration_order_or_cycles: Crash |
| +inference/infer_type_regardless_of_declaration_order_or_cycles_b: Crash |
| inference/infer_typed_map_literal: Crash |
| inference/infer_types_on_generic_instantiations_3: Crash |
| inference/infer_types_on_generic_instantiations_4: Crash |
| @@ -230,12 +242,13 @@ inference/infer_types_on_generic_instantiations_in_library_cycle: Crash |
| inference/infer_types_on_generic_instantiations_in_library_cycle_a: Crash |
| inference/infer_types_on_generic_instantiations_infer: Crash |
| inference/infer_types_on_loop_indices_for_each_loop: Crash |
| -inference/infer_types_on_loop_indices_for_loop_with_inference: Fail |
| +inference/infer_types_on_loop_indices_for_loop_with_inference: Crash |
| inference/infer_use_of_void: Crash |
| inference/infer_variable_void: Crash |
| inference/inferred_initializing_formal_checks_default_value: Crash |
| inference/inferred_nonstatic_field_depends_on_static_field_complex: Crash |
| inference/inferred_nonstatic_field_depends_on_top_level_var_simple: Crash |
| +inference/inferred_type_block_closure_no_args_no_return: Crash |
| inference/inferred_type_cascade: Crash |
| inference/inferred_type_custom_binary_op: Crash |
| inference/inferred_type_custom_binary_op_via_interface: Crash |
| @@ -267,30 +280,39 @@ inference/instantiate_to_bounds_generic2_has_bound_defined_before: Crash |
| inference/instantiate_to_bounds_generic2_no_bound: Crash |
| inference/instantiate_to_bounds_generic_has_bound_defined_after: Crash |
| inference/instantiate_to_bounds_generic_has_bound_defined_before: Crash |
| -inference/instantiate_to_bounds_invoke_constructor_no_bound: Fail |
| +inference/instantiate_to_bounds_invoke_constructor_no_bound: Crash |
| inference/instantiate_to_bounds_invoke_constructor_type_args_exact: Crash |
| inference/instantiate_to_bounds_not_generic: Crash |
| +inference/int_upwards_local: Crash |
| inference/lambda_does_not_have_propagated_type_hint: Crash |
| inference/lambda_return_type: Crash |
| inference/lambda_void_context: Crash |
| inference/list_literal_typed: Crash |
| +inference/list_literals: Crash |
| +inference/list_literals_can_infer_null_bottom: Crash |
| inference/list_literals_can_infer_null_top_level: Crash |
| inference/list_literals_top_level: Crash |
| inference/local_constructor_from_arguments: Crash |
| +inference/local_reference_upwards_local: Crash |
| inference/local_return_and_yield: Crash |
| -inference/map_literals: Fail |
| -inference/map_literals_can_infer_null: Fail |
| +inference/map_literals: Crash |
| +inference/map_literals_can_infer_null: Crash |
| inference/map_literals_can_infer_null_top_level: Crash |
| inference/map_literals_top_level: Crash |
| inference/method_call_with_type_arguments_instance_method: Crash |
| inference/method_call_with_type_arguments_instance_method_identifier_sequence: Crash |
| inference/method_call_with_type_arguments_static_method: Crash |
| inference/method_call_with_type_arguments_top_level_function: Crash |
| +inference/no_error_when_declared_type_is_num_and_assigned_null: Crash |
| +inference/null_coalescing_operator: Crash |
| +inference/null_coalescing_operator_2: Crash |
| inference/null_literal_should_not_infer_as_bottom: Crash |
| +inference/overloaded_int_operators: Crash |
| inference/propagate_inference_to_field_in_class: Crash |
| inference/propagate_inference_to_field_in_class_dynamic_warnings: Crash |
| -inference/propagate_inference_transitively2: Crash |
| inference/propagate_inference_transitively: Crash |
| +inference/propagate_inference_transitively2: Crash |
| +inference/propagate_variable_get: Crash |
| inference/reference_to_typedef: Crash |
| inference/refine_binary_expression_type_type_parameter_t_double: Crash |
| inference/refine_binary_expression_type_type_parameter_t_int: Crash |
| @@ -306,6 +328,10 @@ inference/top_level_return_and_yield: Crash |
| inference/toplevel_inference_toplevel_var: Crash |
| inference/type_cast: Crash |
| inference/type_promotion_ignores_local_functions: Crash |
| +inference/type_promotion_simple: Crash |
| +inference/type_promotion_stopped_by_access_in_a_closure: Crash |
| +inference/type_promotion_stopped_by_assignment_in_scope: Crash |
| +inference/type_promotion_stopped_by_mutation_in_a_closure: Crash |
| inference/unsafe_block_closure_inference_closure_call: Crash |
| inference/unsafe_block_closure_inference_constructor_call_explicit_dynamic_param: Crash |
| inference/unsafe_block_closure_inference_constructor_call_explicit_type_param: Crash |
| @@ -323,74 +349,82 @@ inference/unsafe_block_closure_inference_function_call_no_type_param: Crash |
| inference/unsafe_block_closure_inference_function_call_no_type_param_via_expr: Crash |
| inference/unsafe_block_closure_inference_in_list_dynamic: Crash |
| inference/unsafe_block_closure_inference_in_list_typed: Crash |
| +inference/unsafe_block_closure_inference_in_list_untyped: Crash |
| inference/unsafe_block_closure_inference_in_map_dynamic: Crash |
| inference/unsafe_block_closure_inference_in_map_typed: Crash |
| +inference/unsafe_block_closure_inference_in_map_untyped: Crash |
| inference/unsafe_block_closure_inference_method_call_explicit_dynamic_param: Crash |
| inference/unsafe_block_closure_inference_method_call_explicit_type_param: Crash |
| inference/unsafe_block_closure_inference_method_call_implicit_type_param: Crash |
| inference/unsafe_block_closure_inference_method_call_no_type_param: Crash |
| inference/void_return_type_subtypes_dynamic: Crash |
| -rasta/abstract_constructor: Fail |
| +rasta/abstract_constructor: Crash |
| rasta/bad_constructor_redirection: Crash |
| rasta/bad_continue: Crash |
| rasta/bad_default_constructor: Crash |
| rasta/bad_explicit_super_constructor: Crash |
| rasta/bad_implicit_super_constructor: Crash |
| -rasta/bad_interpolation: Fail |
| -rasta/bad_redirection: Fail |
| +rasta/bad_interpolation: Crash |
| +rasta/bad_redirection: Crash |
| rasta/bad_setter_initializer: Crash |
| -rasta/bad_unicode: Fail |
| +rasta/bad_unicode: Crash |
| rasta/breaking_bad: Crash |
| rasta/cascades: Crash |
| -rasta/class_hierarchy: Fail |
| +rasta/class_hierarchy: Crash |
| rasta/class_member: Crash |
| rasta/constant_get_and_invoke: Crash |
| -rasta/deferred_lib: Fail |
| +rasta/deferred_lib: Crash |
| rasta/deferred_load: Crash |
| rasta/duplicated_mixin: Crash |
| -rasta/export: Fail |
| +rasta/enum: Crash |
| +rasta/export: Crash |
| rasta/external_factory_redirection: Crash |
| -rasta/foo: Fail |
| -rasta/for_loop: Fail |
| -rasta/generic_factory: Fail # Compile-time error destroys program. |
| +rasta/foo: Crash |
| +rasta/for_loop: Crash |
| +rasta/generic_factory: Crash # Compile-time error destroys program. |
| +rasta/hello: Crash |
| +rasta/import_export: Crash |
| rasta/issue_000001: Crash |
| rasta/issue_000002: Crash |
| rasta/issue_000004: Crash |
| rasta/issue_000006: Crash |
| -rasta/issue_000007: Fail |
| +rasta/issue_000007: Crash |
| rasta/issue_000008: Crash |
| +rasta/issue_000011: Crash |
| rasta/issue_000012: Crash |
| rasta/issue_000025: Crash |
| rasta/issue_000026: Crash |
| rasta/issue_000031: Crash |
| -rasta/issue_000032: Fail |
| +rasta/issue_000032: Crash |
| +rasta/issue_000033: Crash |
| rasta/issue_000034: Crash |
| rasta/issue_000035: Crash |
| -rasta/issue_000035a: Fail |
| -rasta/issue_000036: Fail |
| +rasta/issue_000035a: Crash |
| +rasta/issue_000036: Crash |
| rasta/issue_000039: Crash |
| -rasta/issue_000041: Fail |
| +rasta/issue_000041: Crash |
| rasta/issue_000042: Crash |
| -rasta/issue_000043: Fail |
| -rasta/issue_000044: Fail |
| -rasta/issue_000045: Fail |
| -rasta/issue_000046: Fail |
| -rasta/issue_000047: Fail |
| +rasta/issue_000043: Crash |
| +rasta/issue_000044: Crash |
| +rasta/issue_000045: Crash |
| +rasta/issue_000046: Crash |
| +rasta/issue_000047: Crash |
| rasta/issue_000048: Crash |
| rasta/issue_000052: Crash |
| rasta/issue_000053: Crash |
| rasta/issue_000067: Crash |
| rasta/issue_000068: Crash |
| +rasta/issue_000069: Crash |
| rasta/issue_000070: Crash |
| rasta/issue_000080: Crash |
| rasta/issue_000081: Crash |
| -rasta/malformed_const_constructor: Fail |
| -rasta/malformed_function: VerificationError |
| +rasta/malformed_const_constructor: Crash |
| +rasta/malformed_function: Crash |
| rasta/malformed_function_type: Crash |
| -rasta/mandatory_parameter_initializer: Fail |
| +rasta/mandatory_parameter_initializer: Crash |
| rasta/mixin_library: Crash |
| -rasta/native_is_illegal: Fail |
| +rasta/native_is_illegal: Crash |
| rasta/parser_error: Crash |
| rasta/previsit_deferred: Crash |
| rasta/static: Crash |
| @@ -401,14 +435,14 @@ rasta/super_mixin: Crash |
| rasta/super_operator: Crash |
| rasta/supports_reflection: Crash |
| rasta/switch_execution_case_t02: Crash |
| -rasta/switch_fall_through: Fail |
| +rasta/switch_fall_through: Crash |
| rasta/this_invoke: Crash |
| rasta/try_label: Crash |
| rasta/type_literals: Crash |
| -rasta/type_with_parse_error: Fail |
| +rasta/type_with_parse_error: Crash |
| rasta/typedef: Crash |
| -rasta/unresolved: Fail |
| +rasta/unresolved: Crash |
| rasta/unresolved_constructor: Crash |
| rasta/unresolved_for_in: Crash |
| -rasta/unresolved_recovery: Fail |
| -rasta/unsupported_platform_library: Fail |
| +rasta/unresolved_recovery: Crash |
| +rasta/unsupported_platform_library: Crash |
