[WASM] Use better error message when decoding function body fails.

[WASM] Use better error message when decoding function body fails.

BUG=v8:6325
Review-Url: https://codereview.chromium.org/2904193003
Cr-Commit-Position: refs/heads/master@{#45714}
Committed: https://chromium.googlesource.com/v8/v8/+/911528847ccfded02b8c04c51d1381322e2f34a5

[bbudge, 2017-05-26 19:23:25]

The CQ bit was checked by bbudge@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-26 19:23:33]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[bbudge, 2017-05-26 19:26:27]

bbudge@chromium.org changed reviewers:
+ mtrofin@chromium.org

[bbudge, 2017-05-26 19:26:28]

Code cleanup Friday

[commit-bot: I haz the power, 2017-05-26 19:36:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-26 19:36:35]

Dry run: Try jobs failed on following builders:
  v8_node_linux64_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_node_linux64_rel/builds/...)

[bbudge, 2017-05-31 14:16:58]

Ping

[Mircea Trofin, 2017-05-31 14:51:23]

On 2017/05/31 14:16:58, bbudge wrote:
> Ping

Lgtm, 1 note.

[Mircea Trofin, 2017-05-31 14:51:42]

https://codereview.chromium.org/2904193003/diff/1/src/wasm/module-decoder.cc
File src/wasm/module-decoder.cc (right):

https://codereview.chromium.org/2904193003/diff/1/src/wasm/module-decoder.cc#...
src/wasm/module-decoder.cc:965: result.error(result.error_offset(),
wrapped.str());
Does str() flush?

[bbudge, 2017-06-01 00:53:26]

https://codereview.chromium.org/2904193003/diff/1/src/wasm/module-decoder.cc
File src/wasm/module-decoder.cc (right):

https://codereview.chromium.org/2904193003/diff/1/src/wasm/module-decoder.cc#...
src/wasm/module-decoder.cc:965: result.error(result.error_offset(),
wrapped.str());
On 2017/05/31 14:51:42, Mircea Trofin wrote:
> Does str() flush?

I think flush is a nop on string streams, since data can be written immediately.
The docs say that str() is a copy of the current contents of the stream.

[bbudge, 2017-06-05 20:06:31]

The CQ bit was checked by bbudge@chromium.org

[commit-bot: I haz the power, 2017-06-05 20:06:33]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-05 20:38:57]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1496693191592360, "parent_rev":
"7fa77063cf98cddf5ee721df7279b0f0c8ebf0d3", "commit_rev":
"911528847ccfded02b8c04c51d1381322e2f34a5"}

[commit-bot: I haz the power, 2017-06-05 20:39:04]

Description was changed from

==========
[WASM] Use better error message when decoding function body fails.

BUG=v8:6325
==========

to

==========
[WASM] Use better error message when decoding function body fails.

BUG=v8:6325

Review-Url: https://codereview.chromium.org/2904193003
Cr-Commit-Position: refs/heads/master@{#45714}
Committed:
https://chromium.googlesource.com/v8/v8/+/911528847ccfded02b8c04c51d1381322e2...
==========

[commit-bot: I haz the power, 2017-06-05 20:39:05]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/911528847ccfded02b8c04c51d1381322e2...