color: Perform color transform in ImageBufferSurface

third_party/WebKit/Source/platform/graphics/gpu/AcceleratedImageBufferSurface.cpp

Index: third_party/WebKit/Source/platform/graphics/gpu/AcceleratedImageBufferSurface.cpp
diff --git a/third_party/WebKit/Source/platform/graphics/gpu/AcceleratedImageBufferSurface.cpp b/third_party/WebKit/Source/platform/graphics/gpu/AcceleratedImageBufferSurface.cpp
index fa52e6943b06ae5519dfb976f45c2c00129d054e..2b79255105165022731727f5b94f9ac04c44e86d 100644
--- a/third_party/WebKit/Source/platform/graphics/gpu/AcceleratedImageBufferSurface.cpp
+++ b/third_party/WebKit/Source/platform/graphics/gpu/AcceleratedImageBufferSurface.cpp
@@ -30,6 +30,7 @@
 
 #include "platform/graphics/gpu/AcceleratedImageBufferSurface.h"
 
+#include "platform/RuntimeEnabledFeatures.h"
 #include "platform/graphics/gpu/SharedGpuContext.h"
 #include "platform/graphics/skia/SkiaUtils.h"
 #include "platform/wtf/PtrUtil.h"
@@ -62,7 +63,12 @@ AcceleratedImageBufferSurface::AcceleratedImageBufferSurface(
   if (!surface_)
     return;
 
-  canvas_ = WTF::WrapUnique(new SkiaPaintCanvas(surface_->getCanvas()));
+  canvas_ = WTF::WrapUnique(new SkiaPaintCanvas(
+      surface_->getCanvas(),
+      RuntimeEnabledFeatures::colorCorrectRenderingEnabled() &&

[Justin Novosad, 2017/05/29 14:45:35]

Why is this needed? This calss is not used for rastering. It is only used as a
vehicle for WebGL snapshots.  If you are looking for the place where accelerated
2D canvases are rasterized, that place is Canvas2DLayerBridge.  IMHO, you should
create a gpu-accelerated variant of the color_space virtual test suite.

[ccameron, 2017/05/29 15:27:17]

This looked like the right behavior for offscreen canvas:
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/offscreen...

I don't remember offhand if this was required to fix a particular layout test,
or if this was speculative. Given the SkSurface creation properties, this
definitely feels right.

+              color_params.UsesOutputSpaceBlending()
+          ? color_params.GetSkColorSpace()
+          : nullptr));
   Clear();
 
   // Always save an initial frame, to support resetting the top level matrix