Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 2904123002: Upstream service worker "unregister" tests to WPT (Closed)

Created:
3 years, 6 months ago by mike3
Modified:
3 years, 6 months ago
Reviewers:
falken
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, kenjibaheux+watch_chromium.org, shimazu+serviceworker_chromium.org, serviceworker-reviews, blink-reviews-w3ctests_chromium.org, nhiroki, kinuko+serviceworker, blink-reviews, horo+watch_chromium.org, falken+watch_chromium.org, tzik
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Upstream service worker "unregister" tests to WPT **unregister-controller** The Chromium version of this test is equivalent to the version available in the Web Platform Tests project and may therefore be removed without impacting coverage (along with its associated "resource" file). **unregister-then-register-new-script** The Chromium version of this test is equivalent to the version available in the Web Platform Tests project and may therefore be removed without impacting coverage. Remove the associated "resource" file from the Chromium project because it is no longer referenced by any tests. **unregister-then-register** The Chromium version of this test is largely equivalent to the version available in the Web Platform Tests project and may therefore be removed without impacting coverage. The Chromium includes an additional sub-test, however. Extend the Web Platform Test version with this additional sub-test. Remove an irrelevant comment that describes a possible extension to the test (although the referenced object equality is expected in some contexts, it is not expected in the associated sub-test because the relevant objects are created in distinct JavaScript realms). **unregister** The Chromium version of this test is equivalent to the version available in the Web Platform Tests project and may therefore be removed without impacting coverage. BUG=688116 R=falken@chromium.org Review-Url: https://codereview.chromium.org/2904123002 Cr-Commit-Position: refs/heads/master@{#475298} Committed: https://chromium.googlesource.com/chromium/src/+/b576b1bee0590f3e011cda1652c19057d48f8a93

Patch Set 1 #

Messages

Total messages: 7 (3 generated)
mike3
Hi Matt, This was a fairly straightfoward migration. Would you mind taking a look? Here's ...
3 years, 6 months ago (2017-05-25 21:51:37 UTC) #1
falken
great, lgtm
3 years, 6 months ago (2017-05-29 04:38:13 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2904123002/1
3 years, 6 months ago (2017-05-29 04:41:57 UTC) #4
commit-bot: I haz the power
3 years, 6 months ago (2017-05-29 06:02:36 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b576b1bee0590f3e011cda1652c1...

Powered by Google App Engine
This is Rietveld 408576698