Replacing WM_TOUCH with WM_POINTER for touch events on Wins 8+

ui/base/test/ui_controls.h

Index: ui/base/test/ui_controls.h
diff --git a/ui/base/test/ui_controls.h b/ui/base/test/ui_controls.h
index 4fc54abb126c56a822c587540300e742c586f143..a6a8f3341a44e4feaeab7851d59f9fa95f129315 100644
--- a/ui/base/test/ui_controls.h
+++ b/ui/base/test/ui_controls.h
@@ -80,6 +80,8 @@ enum MouseButtonState {
   DOWN = 2
 };
 
+enum TouchType { PRESS = 1, RELEASE = 1 << 2, MOVE = 1 << 3 };

[sky, 2017/06/22 20:54:22]

Use enum class.

[lanwei, 2017/06/23 20:06:05]

I need to use bit-wise operator, &, |, so I cannot use enum class.

+
 // Sends a mouse down and/or up message. The click will be sent to wherever
 // the cursor currently is, so be sure to move the cursor before calling this
 // (and be sure the cursor has arrived!).
@@ -91,6 +93,14 @@ bool SendMouseEventsNotifyWhenDone(MouseButton type,
 // Same as SendMouseEvents with UP | DOWN.
 bool SendMouseClick(MouseButton type);
 
+bool SendTouchEvents(int action, int num, int x, int y);

[sky, 2017/06/22 20:54:22]

Document what action and num is.

[lanwei, 2017/06/23 20:06:05]

Done.

+
+bool SendTouchEventsNotifyWhenDone(int action,
+                                   int num,
+                                   int x,
+                                   int y,
+                                   const base::Closure& task);

[sky, 2017/06/22 20:54:22]

There is no point in this variant given you can not verify the touch events have
been injected. You should clearly describe that above in SendTouchEvents() and
remove this one.

[lanwei, 2017/06/23 20:06:05]

I removed the function SendTouchEvents, I need a task to keep the callback
function. 

[sky, 2017/06/24 00:01:14]

Why do you need a task? The reason the other variants take a callback is because
the callback is run asynchronously. The function you are adding executes
*synchronously*, because of this there is no reason for this new function to
take a callback. The one place you call this from you have:

ui_controls::SendTouchEventsNotifyWhenDone(
    ui_controls::PRESS, 3, in_content.x(), in_content.y(),
    CreateEventTask(this, &TouchEventsViewTest::Step2));

This is the same thing as:

ui_controls::SendTouchEventsNotifyWhenDone(
    ui_controls::PRESS, 3, in_content.x(), in_content.y());
Step2();

That said, the reason the other tests have multiple functions is because they
are using async API. As your function is synchronous, you don't need Step2().
You can put everything in DoTestOnMessageLoop().

When you remove the callback argument, remove 'NotifyWhenDone' from the name as
it doesn't apply.

And again, clearly document that there is no way to detect when events enter
chrome, it's up to users of this API to detect when events arrive.

[lanwei, 2017/06/26 22:59:28]

Acknowledged.

+
 #if defined(TOOLKIT_VIEWS)
 // Runs |closure| after processing all pending ui events.
 void RunClosureAfterAllPendingUIEvents(const base::Closure& closure);