Upstream service worker "update" tests to WPT

Upstream service worker "update" tests to WPT

**update-served-from-cached**

This test asserts caching behavior, but the relevant standards do not
explicitly require conformance in this regard. The behavior under test
is therefore not generally enforceable in the Web Platform Tests
project. Label the test as Chromium-specific and include an in-line
comment to document this distinction.


**update**

This test exists in both WPT and the Chromium project tree. The WPT
version is slightly weaker because it accounts for a condition that is
not possible according to the latest version of the Service Workers
specification [1].

> # Install
>
> [...]
>
> 16. Run the Update Registration State algorithm passing registration,
>     "waiting" and registration’s installing worker as the arguments.
> 17. Run the Update Registration State algorithm passing registration,
>     "installing" and null as the arguments.
> 18. Run the Update Worker State algorithm passing registration’s
>     waiting worker and installed as the arguments.
> 19. Invoke Finish Job with job.
> 20. Wait for all the tasks queued by Update Worker State invoked in
>     this algorithm have executed.
> 21. Invoke Try Activate with registration.

Due to step 20, worker activation does not occur until all prior tasks
(which includes microtasks such as the Promise handler microtask created
in the test's body) have executed.

Remove the conditional logic from the WPT version. Ensure
iframe removal takes place regardless of test outcome. Add a 'use
strict' directive to script body. Remove unnecessary invocation of
`Test#done`. Remove the Chromium version of the test.

[1] https://w3c.github.io/ServiceWorker/#installation-algorithm
    retrieved on 17.05.25

BUG=688116
R=falken@chromium.org

Review-Url: https://codereview.chromium.org/2904063003
Cr-Commit-Position: refs/heads/master@{#475294}
Committed: https://chromium.googlesource.com/chromium/src/+/ebf9c47dfbfe4bba16e5e7997fb382603e3c2de2

[mike3, 2017-05-25 21:29:16]

Description was changed from

==========
Upstream service worker "update" tests to WPT

**update-served-from-cached**

Migrate the test to the Web Platform Tests infrastructure, updating URLs
as appropriate. Insert a "use strict" directive.

**update**

This test exists in both WPT and the Chromium project tree. The WPT
version is slightly weaker because it accounts for a condition that is
not possible according to the latest version of the Service Workers
specification [1].

> # Install
>
> [...]
>
> 16. Run the Update Registration State algorithm passing registration,
>     "waiting" and registration’s installing worker as the arguments.
> 17. Run the Update Registration State algorithm passing registration,
>     "installing" and null as the arguments.
> 18. Run the Update Worker State algorithm passing registration’s
>     waiting worker and installed as the arguments.
> 19. Invoke Finish Job with job.
> 20. Wait for all the tasks queued by Update Worker State invoked in
>     this algorithm have executed.
> 21. Invoke Try Activate with registration.

Due to step 20, worker activation does not occur until all prior tasks
(which includes microtasks such as the Promise handler microtask created
in the test's body) have executed.

Remove the conditional logic from the WPT version. Ensure
iframe removal takes place regardless of test outcome. Add a 'use
strict' directive to script body. Remove unnecessary invocation of
`Test#done`. Remove the Chromium version of the test.

[1] https://w3c.github.io/ServiceWorker/#installation-algorithm
    retrieved on 17.05.25

BUG=688116
R=falken@chromium.org
==========

to

==========
Upstream service worker "update" tests to WPT

**update-served-from-cached**

This test asserts caching behavior, but the relevant standards do not
explicitly require conformance in this regard. The behavior under test
is therefore not generally enforceable in the Web Platform Tests
project. Label the test as Chromium-specific and include an in-line
comment to document this distinction.


**update**

This test exists in both WPT and the Chromium project tree. The WPT
version is slightly weaker because it accounts for a condition that is
not possible according to the latest version of the Service Workers
specification [1].

> # Install
>
> [...]
>
> 16. Run the Update Registration State algorithm passing registration,
>     "waiting" and registration’s installing worker as the arguments.
> 17. Run the Update Registration State algorithm passing registration,
>     "installing" and null as the arguments.
> 18. Run the Update Worker State algorithm passing registration’s
>     waiting worker and installed as the arguments.
> 19. Invoke Finish Job with job.
> 20. Wait for all the tasks queued by Update Worker State invoked in
>     this algorithm have executed.
> 21. Invoke Try Activate with registration.

Due to step 20, worker activation does not occur until all prior tasks
(which includes microtasks such as the Promise handler microtask created
in the test's body) have executed.

Remove the conditional logic from the WPT version. Ensure
iframe removal takes place regardless of test outcome. Add a 'use
strict' directive to script body. Remove unnecessary invocation of
`Test#done`. Remove the Chromium version of the test.

[1] https://w3c.github.io/ServiceWorker/#installation-algorithm
    retrieved on 17.05.25

BUG=688116
R=falken@chromium.org
==========

[mike3, 2017-05-25 21:46:22]

Hi Matt,

Here's a comparison of the migrated test files before application of this
patch. I've included a diff between the Python and PHP scripts because I
thought it might be more convenient to verify equivalency this way (despite the
fact that their text is completely distinct):

https://gist.github.com/jugglinmike/a67f822f9f42343d6b422d000fbb2b39

The test `update-served-from-cache` had me scratching my head for a while. I
decided on this resolution after working with Mek on IRC and following up with
a discussion on the net-dev mailing list:

https://groups.google.com/a/chromium.org/forum/#!topic/net-dev/wbhbSn9ICfc

[falken, 2017-05-29 04:35:08]

Thanks for the detailed investigation and following up on net-dev. It's
interesting that cache behavior won't be testable in WPT tests. I think your
conclusion is sound.

lgtm.

[falken, 2017-05-29 04:41:24]

The CQ bit was checked by falken@chromium.org

[commit-bot: I haz the power, 2017-05-29 04:41:44]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-29 05:56:38]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1496032884753520,
"parent_rev": "e6a7d7e3cd5665b6bc9b0e8cac4c813c52f90b02", "commit_rev":
"ebf9c47dfbfe4bba16e5e7997fb382603e3c2de2"}

[commit-bot: I haz the power, 2017-05-29 05:56:48]

Description was changed from

==========
Upstream service worker "update" tests to WPT

**update-served-from-cached**

This test asserts caching behavior, but the relevant standards do not
explicitly require conformance in this regard. The behavior under test
is therefore not generally enforceable in the Web Platform Tests
project. Label the test as Chromium-specific and include an in-line
comment to document this distinction.


**update**

This test exists in both WPT and the Chromium project tree. The WPT
version is slightly weaker because it accounts for a condition that is
not possible according to the latest version of the Service Workers
specification [1].

> # Install
>
> [...]
>
> 16. Run the Update Registration State algorithm passing registration,
>     "waiting" and registration’s installing worker as the arguments.
> 17. Run the Update Registration State algorithm passing registration,
>     "installing" and null as the arguments.
> 18. Run the Update Worker State algorithm passing registration’s
>     waiting worker and installed as the arguments.
> 19. Invoke Finish Job with job.
> 20. Wait for all the tasks queued by Update Worker State invoked in
>     this algorithm have executed.
> 21. Invoke Try Activate with registration.

Due to step 20, worker activation does not occur until all prior tasks
(which includes microtasks such as the Promise handler microtask created
in the test's body) have executed.

Remove the conditional logic from the WPT version. Ensure
iframe removal takes place regardless of test outcome. Add a 'use
strict' directive to script body. Remove unnecessary invocation of
`Test#done`. Remove the Chromium version of the test.

[1] https://w3c.github.io/ServiceWorker/#installation-algorithm
    retrieved on 17.05.25

BUG=688116
R=falken@chromium.org
==========

to

==========
Upstream service worker "update" tests to WPT

**update-served-from-cached**

This test asserts caching behavior, but the relevant standards do not
explicitly require conformance in this regard. The behavior under test
is therefore not generally enforceable in the Web Platform Tests
project. Label the test as Chromium-specific and include an in-line
comment to document this distinction.


**update**

This test exists in both WPT and the Chromium project tree. The WPT
version is slightly weaker because it accounts for a condition that is
not possible according to the latest version of the Service Workers
specification [1].

> # Install
>
> [...]
>
> 16. Run the Update Registration State algorithm passing registration,
>     "waiting" and registration’s installing worker as the arguments.
> 17. Run the Update Registration State algorithm passing registration,
>     "installing" and null as the arguments.
> 18. Run the Update Worker State algorithm passing registration’s
>     waiting worker and installed as the arguments.
> 19. Invoke Finish Job with job.
> 20. Wait for all the tasks queued by Update Worker State invoked in
>     this algorithm have executed.
> 21. Invoke Try Activate with registration.

Due to step 20, worker activation does not occur until all prior tasks
(which includes microtasks such as the Promise handler microtask created
in the test's body) have executed.

Remove the conditional logic from the WPT version. Ensure
iframe removal takes place regardless of test outcome. Add a 'use
strict' directive to script body. Remove unnecessary invocation of
`Test#done`. Remove the Chromium version of the test.

[1] https://w3c.github.io/ServiceWorker/#installation-algorithm
    retrieved on 17.05.25

BUG=688116
R=falken@chromium.org

Review-Url: https://codereview.chromium.org/2904063003
Cr-Commit-Position: refs/heads/master@{#475294}
Committed:
https://chromium.googlesource.com/chromium/src/+/ebf9c47dfbfe4bba16e5e7997fb3...
==========

[commit-bot: I haz the power, 2017-05-29 05:56:49]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/ebf9c47dfbfe4bba16e5e7997fb3...