ios/clean/chrome/browser/ui/tab_collection/tab_collection_consumer.h - Issue 2904053002: [ios] Active web state observer in tab collection.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/clean/chrome/browser/ui/tab_collection/tab_collection_consumer.h

Issue 2904053002: [ios] Active web state observer in tab collection. (Closed)

Patch Set: Address comments. Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« ios/clean/chrome/browser/ui/find_in_page/find_in_page_mediator.mm ('K') | « ios/clean/chrome/browser/ui/find_in_page/find_in_page_mediator.mm ('k') | ios/clean/chrome/browser/ui/tab_collection/tab_collection_mediator.mm » ('j') | ios/clean/chrome/browser/ui/tab_collection/tab_collection_mediator.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ios/clean/chrome/browser/ui/tab_collection/tab_collection_consumer.h

diff --git a/ios/clean/chrome/browser/ui/tab_collection/tab_collection_consumer.h b/ios/clean/chrome/browser/ui/tab_collection/tab_collection_consumer.h

index 1ca74ee3e1506288f08ec24ddcc19a0c11d521d1..f3e83bc676f352883f9d46f437561a4729a184c2 100644

--- a/ios/clean/chrome/browser/ui/tab_collection/tab_collection_consumer.h

+++ b/ios/clean/chrome/browser/ui/tab_collection/tab_collection_consumer.h

@@ -11,13 +11,17 @@

@protocol TabCollectionConsumer

// Inserts |item| into tab collection at |index|.

marq (ping after 24h) 2017/05/30 11:09:43 Here and below: document what |selectedIndex| mean

edchin 2017/06/01 23:52:28 Done.

-- (void)insertItem:(TabCollectionItem*)item atIndex:(int)index;

+- (void)insertItem:(TabCollectionItem*)item

+ atIndex:(int)index

+ selectedIndex:(int)selectedIndex;

// Deletes |index| from tab collection.

-- (void)deleteItemAtIndex:(int)index;

+- (void)deleteItemAtIndex:(int)index selectedIndex:(int)selectedIndex;

// Moves item from |fromIndex| to |toIndex|.

-- (void)moveItemFromIndex:(int)fromIndex toIndex:(int)toIndex;

+- (void)moveItemFromIndex:(int)fromIndex

+ toIndex:(int)toIndex

+ selectedIndex:(int)selectedIndex;

// Replaces item at |index| with |item|.

- (void)replaceItemAtIndex:(int)index withItem:(TabCollectionItem*)item;

marq (ping after 24h) 2017/05/30 11:09:43 Does this also need a |selectedIndex| parameter?

edchin 2017/06/01 23:52:28 The selection does not change with a replace.

@@ -26,7 +30,8 @@

- (void)selectItemAtIndex:(int)index;

// Populates tab collection with |items|.

-- (void)populateItems:(NSArray<TabCollectionItem*>*)items;

+- (void)populateItems:(NSArray<TabCollectionItem*>*)items

+ selectedIndex:(int)selectedIndex;

@end

#endif // IOS_CLEAN_CHROME_BROWSER_UI_TAB_COLLECTION_TAB_COLLECTION_CONSUMER_H_