[ios] Active web state observer in tab collection.

ios/clean/chrome/browser/ui/tab_collection/tab_collection_consumer.h

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef IOS_CLEAN_CHROME_BROWSER_UI_TAB_COLLECTION_TAB_COLLECTION_CONSUMER_H_
 #define IOS_CLEAN_CHROME_BROWSER_UI_TAB_COLLECTION_TAB_COLLECTION_CONSUMER_H_
 
 @class TabCollectionItem;
 
 // Interface to support insert/delete/updates to a tab collection.
 @protocol TabCollectionConsumer
 
 // Inserts |item| into tab collection at |index|.

[marq (ping after 24h), 2017/05/30 11:09:43]

Here and below: document what |selectedIndex| means.

[edchin, 2017/06/01 23:52:28]

Done.

-- (void)insertItem:(TabCollectionItem*)item atIndex:(int)index;
+- (void)insertItem:(TabCollectionItem*)item
+           atIndex:(int)index
+     selectedIndex:(int)selectedIndex;
 
 // Deletes |index| from tab collection.
-- (void)deleteItemAtIndex:(int)index;
+- (void)deleteItemAtIndex:(int)index selectedIndex:(int)selectedIndex;
 
 // Moves item from |fromIndex| to |toIndex|.
-- (void)moveItemFromIndex:(int)fromIndex toIndex:(int)toIndex;
+- (void)moveItemFromIndex:(int)fromIndex
+                  toIndex:(int)toIndex
+            selectedIndex:(int)selectedIndex;
 
 // Replaces item at |index| with |item|.
 - (void)replaceItemAtIndex:(int)index withItem:(TabCollectionItem*)item;

[marq (ping after 24h), 2017/05/30 11:09:43]

Does this also need a |selectedIndex| parameter?

[edchin, 2017/06/01 23:52:28]

The selection does not change with a replace.

 
 // Selects the item at |index|.
 - (void)selectItemAtIndex:(int)index;
 
 // Populates tab collection with |items|.
-- (void)populateItems:(NSArray<TabCollectionItem*>*)items;
+- (void)populateItems:(NSArray<TabCollectionItem*>*)items
+        selectedIndex:(int)selectedIndex;
 @end
 
 #endif  // IOS_CLEAN_CHROME_BROWSER_UI_TAB_COLLECTION_TAB_COLLECTION_CONSUMER_H_