Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 2904043002: Remove insecure code paths in portable NTLM. (Closed)

Created:
3 years, 7 months ago by zentaro
Modified:
3 years, 7 months ago
Reviewers:
asanka, Ryan Sleevi
CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove insecure code paths in portable NTLM. - Removes some dead code - Always use extended session security BUG=chromium:726080 TEST=unit tests and manual Review-Url: https://codereview.chromium.org/2904043002 Cr-Commit-Position: refs/heads/master@{#474661} Committed: https://chromium.googlesource.com/chromium/src/+/a6af46e2458df233a06576a074e198036822ce34

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -70 lines) Patch
M net/http/http_auth_handler_ntlm_portable.cc View 3 chunks +11 lines, -70 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
zentaro
3 years, 7 months ago (2017-05-25 13:51:49 UTC) #3
Ryan Sleevi
lgtm
3 years, 7 months ago (2017-05-25 14:03:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2904043002/1
3 years, 7 months ago (2017-05-25 14:08:04 UTC) #6
commit-bot: I haz the power
3 years, 7 months ago (2017-05-25 15:44:14 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a6af46e2458df233a06576a074e1...

Powered by Google App Engine
This is Rietveld 408576698