Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Issue 2904023002: Revert of Update PaintTiming Web Perf APIs for FP & FCP to report swap time (Closed)

Created:
3 years, 7 months ago by yosin_UTC9
Modified:
3 years, 7 months ago
Reviewers:
Xianzhu, tdresser, panicker
CC:
chromium-reviews, blink-reviews, dshwang, blink-reviews-paint_chromium.org, Zhen Wang
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Update PaintTiming Web Perf APIs for FP & FCP to report swap time (patchset #3 id:40001 of https://codereview.chromium.org/2873033002/ ) Reason for revert: Probably causes leaks: * http/tests/performance-timing/paint-timing/observable.html * virtual/mojo-loading/http/tests/performance-timing/paint-timing/observable.html https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty%20Leak/builds/4956 Original issue's description: > Update PaintTiming Web Perf APIs for FP & FCP to report swap time > > BUG=657826, 657825 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 > > Review-Url: https://codereview.chromium.org/2873033002 > Cr-Commit-Position: refs/heads/master@{#474504} > Committed: https://chromium.googlesource.com/chromium/src/+/e7366cc17bd54dc1f347e98e40668cf845e472b5 TBR=tdresser@chromium.org,wangxianzhu@chromium.org,panicker@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=657826, 657825 Review-Url: https://codereview.chromium.org/2904023002 Cr-Commit-Position: refs/heads/master@{#474590} Committed: https://chromium.googlesource.com/chromium/src/+/fc1fe7bf2508b1301933004e0f4e44bf55b3032a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -20 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +0 lines, -10 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/performance-timing/paint-timing/observable.html View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintTiming.cpp View 3 chunks +8 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
yosin_UTC9
Created Revert of Update PaintTiming Web Perf APIs for FP & FCP to report swap ...
3 years, 7 months ago (2017-05-25 06:51:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2904023002/1
3 years, 7 months ago (2017-05-25 06:52:16 UTC) #3
commit-bot: I haz the power
3 years, 7 months ago (2017-05-25 06:52:55 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/fc1fe7bf2508b1301933004e0f4e...

Powered by Google App Engine
This is Rietveld 408576698