Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Issue 2903933002: Re-enable PrefHashBrowserTest with a few more mitigations and cleanups. (Closed)

Created:
3 years, 7 months ago by gab
Modified:
3 years, 7 months ago
Reviewers:
proberge
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-enable PrefHashBrowserTest with a few more mitigations and cleanups. BUG=723639, 721245 Review-Url: https://codereview.chromium.org/2903933002 Cr-Commit-Position: refs/heads/master@{#474390} Committed: https://chromium.googlesource.com/chromium/src/+/36b8552bced16b02fb080f98738087678accf273

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -30 lines) Patch
M chrome/browser/prefs/tracked/pref_hash_browsertest.cc View 13 chunks +29 lines, -30 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
gab
Pierre-Alexandre PTaL, thanks!
3 years, 7 months ago (2017-05-24 18:45:23 UTC) #4
proberge
lgtm
3 years, 7 months ago (2017-05-24 18:58:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2903933002/1
3 years, 7 months ago (2017-05-24 19:23:14 UTC) #8
commit-bot: I haz the power
3 years, 7 months ago (2017-05-24 19:31:05 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/36b8552bced16b02fb080f987380...

Powered by Google App Engine
This is Rietveld 408576698