Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 2903923003: Record print job success and print queue size. (Closed)

Created:
3 years, 6 months ago by skau
Modified:
3 years, 6 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Record print job success and print queue size. Record two new metrics for Chrome OS. CUPS.PrintJobsQueued records the number of print jobs in the queue when a job is started. CUPS.JobResult records if a print job failed and why it failed. BUG=725740 Review-Url: https://codereview.chromium.org/2903923003 Cr-Commit-Position: refs/heads/master@{#474805} Committed: https://chromium.googlesource.com/chromium/src/+/71cedf9cc39e53e0341dd3dc4b4d7139376dbd48

Patch Set 1 #

Patch Set 2 : typo #

Patch Set 3 : fix histograms #

Total comments: 6

Patch Set 4 : address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -0 lines) Patch
M chrome/browser/chromeos/printing/cups_print_job_manager_impl.cc View 1 2 3 5 chunks +39 lines, -0 lines 0 comments Download
M tools/metrics/histograms/enums.xml View 1 1 chunk +8 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 3 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
skau
asvitkine@: metrics justincarlon@: all
3 years, 6 months ago (2017-05-24 23:17:40 UTC) #2
Alexei Svitkine (slow)
https://codereview.chromium.org/2903923003/diff/40001/chrome/browser/chromeos/printing/cups_print_job_manager_impl.cc File chrome/browser/chromeos/printing/cups_print_job_manager_impl.cc (right): https://codereview.chromium.org/2903923003/diff/40001/chrome/browser/chromeos/printing/cups_print_job_manager_impl.cc#newcode418 chrome/browser/chromeos/printing/cups_print_job_manager_impl.cc:418: UMA_HISTOGRAM_ENUMERATION("CUPS.JobResult", LOST, RESULT_MAX); Please make a helper function for ...
3 years, 6 months ago (2017-05-25 15:13:56 UTC) #3
Carlson
lgtm https://codereview.chromium.org/2903923003/diff/40001/chrome/browser/chromeos/printing/cups_print_job_manager_impl.cc File chrome/browser/chromeos/printing/cups_print_job_manager_impl.cc (right): https://codereview.chromium.org/2903923003/diff/40001/chrome/browser/chromeos/printing/cups_print_job_manager_impl.cc#newcode51 chrome/browser/chromeos/printing/cups_print_job_manager_impl.cc:51: enum JobResult { If this is specific to ...
3 years, 6 months ago (2017-05-25 16:27:17 UTC) #4
skau
Comments addressed. PTAL. https://codereview.chromium.org/2903923003/diff/40001/chrome/browser/chromeos/printing/cups_print_job_manager_impl.cc File chrome/browser/chromeos/printing/cups_print_job_manager_impl.cc (right): https://codereview.chromium.org/2903923003/diff/40001/chrome/browser/chromeos/printing/cups_print_job_manager_impl.cc#newcode51 chrome/browser/chromeos/printing/cups_print_job_manager_impl.cc:51: enum JobResult { On 2017/05/25 16:27:17, ...
3 years, 6 months ago (2017-05-25 18:45:40 UTC) #5
Alexei Svitkine (slow)
lgtm
3 years, 6 months ago (2017-05-25 18:47:57 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2903923003/60001
3 years, 6 months ago (2017-05-25 19:25:10 UTC) #9
commit-bot: I haz the power
3 years, 6 months ago (2017-05-25 21:13:40 UTC) #12
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/71cedf9cc39e53e0341dd3dc4b4d...

Powered by Google App Engine
This is Rietveld 408576698