Record print job success and print queue size.

Record print job success and print queue size.

Record two new metrics for Chrome OS.  CUPS.PrintJobsQueued records the
number of print jobs in the queue when a job is started.  CUPS.JobResult
records if a print job failed and why it failed.

BUG=725740
Review-Url: https://codereview.chromium.org/2903923003
Cr-Commit-Position: refs/heads/master@{#474805}
Committed: https://chromium.googlesource.com/chromium/src/+/71cedf9cc39e53e0341dd3dc4b4d7139376dbd48

[skau, 2017-05-24 23:17:39]

skau@chromium.org changed reviewers:
+ asvitkine@chromium.org, justincarlson@chromium.org

[skau, 2017-05-24 23:17:40]

asvitkine@: metrics
justincarlon@: all

[Alexei Svitkine (slow), 2017-05-25 15:13:56]

https://codereview.chromium.org/2903923003/diff/40001/chrome/browser/chromeos...
File chrome/browser/chromeos/printing/cups_print_job_manager_impl.cc (right):

https://codereview.chromium.org/2903923003/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/printing/cups_print_job_manager_impl.cc:418:
UMA_HISTOGRAM_ENUMERATION("CUPS.JobResult", LOST, RESULT_MAX);
Please make a helper function for logging this histogram. Each macro expands to
a lot of code, so not duplicating them helps.

https://codereview.chromium.org/2903923003/diff/40001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2903923003/diff/40001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:9818: +<histogram name="CUPS.JobResult"
enum="PrintJobResult">
Suggest using a more general top-level prefix, like Printing.

e.g. Printing.CUPS.JobResult

[Carlson, 2017-05-25 16:27:17]

lgtm

https://codereview.chromium.org/2903923003/diff/40001/chrome/browser/chromeos...
File chrome/browser/chromeos/printing/cups_print_job_manager_impl.cc (right):

https://codereview.chromium.org/2903923003/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/printing/cups_print_job_manager_impl.cc:51: enum
JobResult {
If this is specific to histograms, can the enum name reflect that?  This is a
pretty generic name.

[skau, 2017-05-25 18:45:40]

Comments addressed.  PTAL.

https://codereview.chromium.org/2903923003/diff/40001/chrome/browser/chromeos...
File chrome/browser/chromeos/printing/cups_print_job_manager_impl.cc (right):

https://codereview.chromium.org/2903923003/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/printing/cups_print_job_manager_impl.cc:51: enum
JobResult {
On 2017/05/25 16:27:17, Carlson wrote:
> If this is specific to histograms, can the enum name reflect that?  This is a
> pretty generic name.

Done.

https://codereview.chromium.org/2903923003/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/printing/cups_print_job_manager_impl.cc:418:
UMA_HISTOGRAM_ENUMERATION("CUPS.JobResult", LOST, RESULT_MAX);
On 2017/05/25 15:13:56, Alexei Svitkine (slow) wrote:
> Please make a helper function for logging this histogram. Each macro expands
to
> a lot of code, so not duplicating them helps.

Done.

https://codereview.chromium.org/2903923003/diff/40001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2903923003/diff/40001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:9818: +<histogram name="CUPS.JobResult"
enum="PrintJobResult">
On 2017/05/25 15:13:56, Alexei Svitkine (slow) wrote:
> Suggest using a more general top-level prefix, like Printing.
> 
> e.g. Printing.CUPS.JobResult

Done.

[Alexei Svitkine (slow), 2017-05-25 18:47:57]

lgtm

[skau, 2017-05-25 19:24:27]

The CQ bit was checked by skau@chromium.org

[skau, 2017-05-25 19:24:27]

The patchset sent to the CQ was uploaded after l-g-t-m from
justincarlson@chromium.org
Link to the patchset: https://codereview.chromium.org/2903923003/#ps60001
(title: "address comments")

[commit-bot: I haz the power, 2017-05-25 19:25:10]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-25 21:13:24]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1495740267135360,
"parent_rev": "4c69297c5da0d7332ee3a24a985fcc0b89ce3cc1", "commit_rev":
"71cedf9cc39e53e0341dd3dc4b4d7139376dbd48"}

[commit-bot: I haz the power, 2017-05-25 21:13:38]

Description was changed from

==========
Record print job success and print queue size.

Record two new metrics for Chrome OS.  CUPS.PrintJobsQueued records the
number of print jobs in the queue when a job is started.  CUPS.JobResult
records if a print job failed and why it failed.

BUG=725740
==========

to

==========
Record print job success and print queue size.

Record two new metrics for Chrome OS.  CUPS.PrintJobsQueued records the
number of print jobs in the queue when a job is started.  CUPS.JobResult
records if a print job failed and why it failed.

BUG=725740

Review-Url: https://codereview.chromium.org/2903923003
Cr-Commit-Position: refs/heads/master@{#474805}
Committed:
https://chromium.googlesource.com/chromium/src/+/71cedf9cc39e53e0341dd3dc4b4d...
==========

[commit-bot: I haz the power, 2017-05-25 21:13:40]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/71cedf9cc39e53e0341dd3dc4b4d...