third_party/WebKit/Source/core/dom/ModulatorImpl.h - Issue 2903813002: [ES6 modules] Fix context leak. ModuleScript should use TraceWrapperV8Reference to hold onto v8::Mo…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/ModulatorImpl.h

Issue 2903813002: [ES6 modules] Fix context leak. ModuleScript should use TraceWrapperV8Reference to hold onto v8::Mo… (Closed)

Patch Set: testfix Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/dom/ModulatorImpl.h

diff --git a/third_party/WebKit/Source/core/dom/ModulatorImpl.h b/third_party/WebKit/Source/core/dom/ModulatorImpl.h

index fe7d7527a71b900b02547d10757fbc3cca08bae8..e0af1850d57dcd9d16fecd4c49ad55f24c85910e 100644

--- a/third_party/WebKit/Source/core/dom/ModulatorImpl.h

+++ b/third_party/WebKit/Source/core/dom/ModulatorImpl.h

@@ -43,6 +43,7 @@ class ModulatorImpl final : public Modulator {

WebTaskRunner* TaskRunner() override { return task_runner_.Get(); }

ReferrerPolicy GetReferrerPolicy() override;

SecurityOrigin* GetSecurityOrigin() override;

+ ScriptState* GetScriptState() override { return script_state_.Get(); }

void FetchTree(const ModuleScriptFetchRequest&, ModuleTreeClient*) override;

void FetchDescendantsForInlineScript(ModuleScript*,