Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Side by Side Diff: third_party/WebKit/Source/core/dom/ModulatorImpl.h

Issue 2903813002: [ES6 modules] Fix context leak. ModuleScript should use TraceWrapperV8Reference to hold onto v8::Mo… (Closed)
Patch Set: testfix Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2017 The Chromium Authors. All rights reserved. 1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef ModulatorImpl_h 5 #ifndef ModulatorImpl_h
6 #define ModulatorImpl_h 6 #define ModulatorImpl_h
7 7
8 #include "bindings/core/v8/ScriptModule.h" 8 #include "bindings/core/v8/ScriptModule.h"
9 #include "core/dom/Modulator.h" 9 #include "core/dom/Modulator.h"
10 #include "platform/bindings/ScriptWrappable.h" 10 #include "platform/bindings/ScriptWrappable.h"
(...skipping 25 matching lines...) Expand all
36 36
37 private: 37 private:
38 // Implements Modulator 38 // Implements Modulator
39 39
40 ScriptModuleResolver* GetScriptModuleResolver() override { 40 ScriptModuleResolver* GetScriptModuleResolver() override {
41 return script_module_resolver_.Get(); 41 return script_module_resolver_.Get();
42 } 42 }
43 WebTaskRunner* TaskRunner() override { return task_runner_.Get(); } 43 WebTaskRunner* TaskRunner() override { return task_runner_.Get(); }
44 ReferrerPolicy GetReferrerPolicy() override; 44 ReferrerPolicy GetReferrerPolicy() override;
45 SecurityOrigin* GetSecurityOrigin() override; 45 SecurityOrigin* GetSecurityOrigin() override;
46 ScriptState* GetScriptState() override { return script_state_.Get(); }
46 47
47 void FetchTree(const ModuleScriptFetchRequest&, ModuleTreeClient*) override; 48 void FetchTree(const ModuleScriptFetchRequest&, ModuleTreeClient*) override;
48 void FetchDescendantsForInlineScript(ModuleScript*, 49 void FetchDescendantsForInlineScript(ModuleScript*,
49 ModuleTreeClient*) override; 50 ModuleTreeClient*) override;
50 void FetchTreeInternal(const ModuleScriptFetchRequest&, 51 void FetchTreeInternal(const ModuleScriptFetchRequest&,
51 const AncestorList&, 52 const AncestorList&,
52 ModuleGraphLevel, 53 ModuleGraphLevel,
53 ModuleTreeClient*) override; 54 ModuleTreeClient*) override;
54 void FetchSingle(const ModuleScriptFetchRequest&, 55 void FetchSingle(const ModuleScriptFetchRequest&,
55 ModuleGraphLevel, 56 ModuleGraphLevel,
(...skipping 21 matching lines...) Expand all
77 Member<ResourceFetcher> fetcher_; 78 Member<ResourceFetcher> fetcher_;
78 TraceWrapperMember<ModuleMap> map_; 79 TraceWrapperMember<ModuleMap> map_;
79 Member<ModuleScriptLoaderRegistry> loader_registry_; 80 Member<ModuleScriptLoaderRegistry> loader_registry_;
80 Member<ModuleTreeLinkerRegistry> tree_linker_registry_; 81 Member<ModuleTreeLinkerRegistry> tree_linker_registry_;
81 Member<ScriptModuleResolver> script_module_resolver_; 82 Member<ScriptModuleResolver> script_module_resolver_;
82 }; 83 };
83 84
84 } // namespace blink 85 } // namespace blink
85 86
86 #endif 87 #endif
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/dom/Modulator.h ('k') | third_party/WebKit/Source/core/dom/ModuleScript.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698