Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2903803003:
[Payments] Pass stringified details for service worker based payment app response (Closed)
|
Created:
3 years, 7 months ago by gogerald1 Modified:
3 years, 7 months ago Reviewers:
Marijn Kruisselbrink CC:
blink-worker-reviews_chromium.org, chromium-reviews, darin-cc_chromium.org, horo+watch_chromium.org, jam, zino, jsbell+serviceworker_chromium.org, kinuko+watch, kinuko+serviceworker, michaeln, mlamouri+watch-content_chromium.org, nhiroki, please use gerrit instead, serviceworker-reviews, shimazu+serviceworker_chromium.org, tzik Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionPass stringified details for service worker based payment app response
This CL adds the missing field in https://codereview.chromium.org/2718013004
BUG=720027
Review-Url: https://codereview.chromium.org/2903803003
Cr-Commit-Position: refs/heads/master@{#475075}
Committed: https://chromium.googlesource.com/chromium/src/+/13eace280f457bc0c065f05a415dc02b07fbb9af
Patch Set 1 #
Messages
Total messages: 17 (12 generated)
The CQ bit was checked by gogerald@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Pass stringified details for service worker based payment app response BUG= ========== to ========== Pass stringified details for service worker based payment app response BUG=720027 ==========
gogerald@chromium.org changed reviewers: + mek@chromium.org
Hi mek@, ptal,
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm, but since this looks like fixing a bug with a previous CL, could you include a link to the CL that originally added this code to the description?
Description was changed from ========== Pass stringified details for service worker based payment app response BUG=720027 ========== to ========== Pass stringified details for service worker based payment app response This is a fix of the CL https://codereview.chromium.org/2718013004 BUG=720027 ==========
Description was changed from ========== Pass stringified details for service worker based payment app response This is a fix of the CL https://codereview.chromium.org/2718013004 BUG=720027 ========== to ========== Pass stringified details for service worker based payment app response This fixed the missing field in the CL https://codereview.chromium.org/2718013004 BUG=720027 ==========
Description was changed from ========== Pass stringified details for service worker based payment app response This fixed the missing field in the CL https://codereview.chromium.org/2718013004 BUG=720027 ========== to ========== Pass stringified details for service worker based payment app response This CL adds the missing field in https://codereview.chromium.org/2718013004 BUG=720027 ==========
Done, thanks, sending to CQ
The CQ bit was checked by gogerald@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1495816747689510, "parent_rev":
"362b7142fe98f5ffb01710124391635a6e6f628f", "commit_rev":
"13eace280f457bc0c065f05a415dc02b07fbb9af"}
Message was sent while issue was closed.
Description was changed from ========== Pass stringified details for service worker based payment app response This CL adds the missing field in https://codereview.chromium.org/2718013004 BUG=720027 ========== to ========== Pass stringified details for service worker based payment app response This CL adds the missing field in https://codereview.chromium.org/2718013004 BUG=720027 Review-Url: https://codereview.chromium.org/2903803003 Cr-Commit-Position: refs/heads/master@{#475075} Committed: https://chromium.googlesource.com/chromium/src/+/13eace280f457bc0c065f05a415d... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/13eace280f457bc0c065f05a415d... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
