Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Issue 2903803002: DOMTokenList should unify duplicated tokens. (Closed)

Created:
3 years, 7 months ago by tkent
Modified:
3 years, 7 months ago
Reviewers:
kochi
CC:
blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-w3ctests_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

DOMTokenList should unify duplicated tokens. The new behavior matches to the DOM standard, Firefox, and Safari. This CL fixes 85 failing WPT tests. BUG=600964 Review-Url: https://codereview.chromium.org/2903803002 Cr-Commit-Position: refs/heads/master@{#474547} Committed: https://chromium.googlesource.com/chromium/src/+/9d5b3e6d930dd8052d1001b52348be1fb0098188

Patch Set 1 #

Patch Set 2 : Update a -expected.txt #

Unified diffs Side-by-side diffs Delta from patch set Stats (+115 lines, -131 lines) Patch
D third_party/WebKit/LayoutTests/external/wpt/dom/lists/DOMTokenList-Iterable-expected.txt View 1 chunk +0 lines, -9 lines 0 comments Download
D third_party/WebKit/LayoutTests/external/wpt/dom/lists/DOMTokenList-iteration-expected.txt View 1 chunk +0 lines, -9 lines 0 comments Download
D third_party/WebKit/LayoutTests/external/wpt/dom/lists/DOMTokenList-value-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/external/wpt/dom/nodes/Element-classlist-expected.txt View 31 chunks +81 lines, -81 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/HTMLElement/class-list-expected.txt View 2 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/HTMLElement/class-list-quirks-expected.txt View 2 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/HTMLElement/resources/class-list.js View 4 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/HTMLOutputElement/dom-token-list.html View 4 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/HTMLOutputElement/dom-token-list-expected.txt View 2 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/frames/sandboxed-iframe-attribute-parsing-03-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/SpaceSplitString.cpp View 1 4 chunks +8 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 15 (11 generated)
tkent
kochi@, would you review this please?
3 years, 7 months ago (2017-05-24 08:17:27 UTC) #4
kochi
lgtm
3 years, 7 months ago (2017-05-24 10:47:30 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2903803002/20001
3 years, 7 months ago (2017-05-24 23:12:55 UTC) #12
commit-bot: I haz the power
3 years, 7 months ago (2017-05-25 04:20:22 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/9d5b3e6d930dd8052d1001b52348...

Powered by Google App Engine
This is Rietveld 408576698