Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1150)

Issue 2903793002: Fix compact infobar's content height. (Closed)

Created:
3 years, 7 months ago by Leo
Modified:
3 years, 7 months ago
Reviewers:
Theresa
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix compact infobar's content height. We enlarged compact infobar's height to 56dp, which causes extra space inside. https://screenshot.googleplex.com/Di57pyX4Q37 This change will keep its content as same as the container. Screenshot after fixed: https://screenshot.googleplex.com/ECaQVWg6rGJ BUG=721943 Review-Url: https://codereview.chromium.org/2903793002 Cr-Commit-Position: refs/heads/master@{#474470} Committed: https://chromium.googlesource.com/chromium/src/+/1a9900ea47c031e6c1f32e5fef106a1844361c61

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/android/java/res/layout/infobar_translate_compact_content.xml View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
Leo
This CL will fix the extra space of the compact infobar.
3 years, 7 months ago (2017-05-24 05:18:43 UTC) #2
Theresa
lgtm
3 years, 7 months ago (2017-05-24 15:07:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2903793002/1
3 years, 7 months ago (2017-05-24 21:39:41 UTC) #6
commit-bot: I haz the power
3 years, 7 months ago (2017-05-24 23:22:38 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1a9900ea47c031e6c1f32e5fef10...

Powered by Google App Engine
This is Rietveld 408576698