Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 2903743003: Remove command-line restriction for comment-signed WebApks. (Closed)

Created:
3 years, 6 months ago by Yaron
Modified:
3 years, 6 months ago
Reviewers:
Xi Han, ScottK
CC:
chromium-reviews, dominickn+watch_chromium.org, pkotwicz+watch_chromium.org, zpeng+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove command-line restriction for comment-signed WebApks. Allows any WebApk signed correctly with comment-signing to receive full-screen treatment BUG=704213 Review-Url: https://codereview.chromium.org/2903743003 Cr-Commit-Position: refs/heads/master@{#474679} Committed: https://chromium.googlesource.com/chromium/src/+/d3e57373452b02aabe667d9027c3e2fad6ac6562

Patch Set 1 #

Patch Set 2 : fix test #

Messages

Total messages: 17 (12 generated)
Yaron
3 years, 6 months ago (2017-05-25 14:59:38 UTC) #10
ScottK
lgtm
3 years, 6 months ago (2017-05-25 15:07:11 UTC) #11
Xi Han
lgtm
3 years, 6 months ago (2017-05-25 15:57:37 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2903743003/20001
3 years, 6 months ago (2017-05-25 16:56:03 UTC) #14
commit-bot: I haz the power
3 years, 6 months ago (2017-05-25 17:01:17 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/d3e57373452b02aabe667d9027c3...

Powered by Google App Engine
This is Rietveld 408576698