memory-infra: LOG(FATAL) on unsupported heap profiler configs

base/trace_event/memory_dump_manager.cc

Index: base/trace_event/memory_dump_manager.cc
diff --git a/base/trace_event/memory_dump_manager.cc b/base/trace_event/memory_dump_manager.cc
index 008b22a2d30be84f4e79db9b2c20de715c7c95ce..719529e45dddbc1da1ae91dcea0d846c6a7a49b6 100644
--- a/base/trace_event/memory_dump_manager.cc
+++ b/base/trace_event/memory_dump_manager.cc
@@ -201,6 +201,18 @@ void MemoryDumpManager::EnableHeapProfilingIfNeeded() {
           switches::kEnableHeapProfiling))
     return;
 
+#if !BUILDFLAG(USE_EXPERIMENTAL_ALLOCATOR_SHIM)

[Wez, 2017/05/24 21:29:25]

Do we ever actually set this under Windows?  The Windows shim code actually
checks for defined(ALLOCATOR_SHIM) (see
https://cs.chromium.org/chromium/src/base/allocator/allocator_shim_win.cc?l=10),
which I think depends on win_allocator_shim in GN.

(Perhaps I'm mis-reading the Windows shim case, though);

[Primiano Tucci (use gerrit), 2017/05/25 10:46:51]

I thought so: 

From build/config/allocator.gni:
if ((is_linux || is_android || is_mac ||(is_win && !is_component_build &&
!is_debug)) && !is_asan && !is_lsan && !is_tsan && !is_msan) {
  _default_use_experimental_allocator_shim = true

then  use_experimental_allocator_shim = _default_use_experimental_allocator_shim

then
in allocator_features.h
  "USE_EXPERIMENTAL_ALLOCATOR_SHIM=$use_experimental_allocator_shim",

The Windows shim code actually
That should be the old shim (Which I am going to kill soon), from the comment:

# The Windows-only allocator shim is only enabled for Release static builds, and
# is mutually exclusive with the generalized shim.
win_use_allocator_shim = is_win && !is_component_build && !is_debug &&
                         !use_experimental_allocator_shim && !is_asan

note the: "!use_experimental_allocator_shim"

+#if defined(OS_WIN)
+  const char kExtraErrMsg[] = "On Windows it requires release + static builds.";
+#else
+  const char kExtraErrMsg[] = "";
+#endif  // defined(OS_WIN)
+  LOG(FATAL) << "--" << switches::kEnableHeapProfiling
+             << " requires building with use_experimental_allocator_shim=true "
+                "(on by default on the major platforms). "
+             << kExtraErrMsg;
+#endif  // BUILDFLAG(USE_EXPERIMENTAL_ALLOCATOR_SHIM)
+
   std::string profiling_mode = CommandLine::ForCurrentProcess()
       ->GetSwitchValueASCII(switches::kEnableHeapProfiling);
   if (profiling_mode == switches::kEnableHeapProfilingModePseudo) {