memory-infra: LOG(FATAL) on unsupported heap profiler configs

base/trace_event/memory_dump_manager.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/trace_event/memory_dump_manager.h"
 
 #include <inttypes.h>
 #include <stdio.h>
 
 #include <algorithm>
@@ skipping 183 matching lines @@
 
 void MemoryDumpManager::EnableHeapProfilingIfNeeded() {
   if (heap_profiling_enabled_)
     return;
 
   if (!CommandLine::InitializedForCurrentProcess() ||
       !CommandLine::ForCurrentProcess()->HasSwitch(
           switches::kEnableHeapProfiling))
     return;
 
+#if !BUILDFLAG(USE_EXPERIMENTAL_ALLOCATOR_SHIM)

[Wez, 2017/05/24 21:29:25]

Do we ever actually set this under Windows?  The Windows shim code actually
checks for defined(ALLOCATOR_SHIM) (see
https://cs.chromium.org/chromium/src/base/allocator/allocator_shim_win.cc?l=10),
which I think depends on win_allocator_shim in GN.

(Perhaps I'm mis-reading the Windows shim case, though);

[Primiano Tucci (use gerrit), 2017/05/25 10:46:51]

I thought so: 

From build/config/allocator.gni:
if ((is_linux || is_android || is_mac ||(is_win && !is_component_build &&
!is_debug)) && !is_asan && !is_lsan && !is_tsan && !is_msan) {
  _default_use_experimental_allocator_shim = true

then  use_experimental_allocator_shim = _default_use_experimental_allocator_shim

then
in allocator_features.h
  "USE_EXPERIMENTAL_ALLOCATOR_SHIM=$use_experimental_allocator_shim",

The Windows shim code actually
That should be the old shim (Which I am going to kill soon), from the comment:

# The Windows-only allocator shim is only enabled for Release static builds, and
# is mutually exclusive with the generalized shim.
win_use_allocator_shim = is_win && !is_component_build && !is_debug &&
                         !use_experimental_allocator_shim && !is_asan

note the: "!use_experimental_allocator_shim"

+#if defined(OS_WIN)
+  const char kExtraErrMsg[] = "On Windows it requires release + static builds.";
+#else
+  const char kExtraErrMsg[] = "";
+#endif  // defined(OS_WIN)
+  LOG(FATAL) << "--" << switches::kEnableHeapProfiling
+             << " requires building with use_experimental_allocator_shim=true "
+                "(on by default on the major platforms). "
+             << kExtraErrMsg;
+#endif  // BUILDFLAG(USE_EXPERIMENTAL_ALLOCATOR_SHIM)
+
   std::string profiling_mode = CommandLine::ForCurrentProcess()
       ->GetSwitchValueASCII(switches::kEnableHeapProfiling);
   if (profiling_mode == switches::kEnableHeapProfilingModePseudo) {
     AllocationContextTracker::SetCaptureMode(
         AllocationContextTracker::CaptureMode::PSEUDO_STACK);
 #if !defined(OS_NACL)
   } else if (profiling_mode == switches::kEnableHeapProfilingModeNative) {
     // If we don't have frame pointers then native tracing falls-back to
     // using base::debug::StackTrace, which may be slow.
     AllocationContextTracker::SetCaptureMode(
@@ skipping 694 matching lines @@
   if (iter == process_dumps.end()) {
     std::unique_ptr<ProcessMemoryDump> new_pmd(
         new ProcessMemoryDump(heap_profiler_serialization_state, dump_args));
     iter = process_dumps.insert(std::make_pair(pid, std::move(new_pmd))).first;
   }
   return iter->second.get();
 }
 
 }  // namespace trace_event
 }  // namespace base