Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(300)

Unified Diff: tools/testing/dart/status_reporter.dart

Issue 2903703002: Tighten types in test.dart even more. (Closed)
Patch Set: Play nicer with strong mode. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/testing/dart/runtime_configuration.dart ('k') | tools/testing/dart/test_configurations.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/status_reporter.dart
diff --git a/tools/testing/dart/status_reporter.dart b/tools/testing/dart/status_reporter.dart
index 734fb262da02fc32668cdb6369e5fe3a328cec20..69c1a0e7f7bd42252def60ac59989bb6a51620da 100644
--- a/tools/testing/dart/status_reporter.dart
+++ b/tools/testing/dart/status_reporter.dart
@@ -149,8 +149,8 @@ void main(List<String> args) {
modes = ['release'].toSet();
} else {
for (var combo in combinations) {
- arches.addAll(combo['archs']);
- modes.addAll(combo['modes']);
+ arches.addAll(combo['archs'] as List<String>);
+ modes.addAll(combo['modes'] as List<String>);
}
}
@@ -169,7 +169,7 @@ void main(List<String> args) {
}
for (var runtime in combination['runtimes']) {
- var compiler = combination['compiler'];
+ var compiler = combination['compiler'] as String;
var args = [
'tools/test.py',
@@ -190,8 +190,8 @@ void main(List<String> args) {
// Find "JSON:"
// Everything after will the JSON-formatted output
// per --report-in-json flag above
- var totalIndex = result.stdout.indexOf('JSON:');
- var report = result.stdout.substring(totalIndex + 5);
+ var totalIndex = (result.stdout as String).indexOf('JSON:');
+ var report = (result.stdout as String).substring(totalIndex + 5);
var map = JSON.decode(report) as Map<String, int>;
« no previous file with comments | « tools/testing/dart/runtime_configuration.dart ('k') | tools/testing/dart/test_configurations.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698