Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(409)

Unified Diff: tools/testing/dart/runtime_configuration.dart

Issue 2903703002: Tighten types in test.dart even more. (Closed)
Patch Set: Play nicer with strong mode. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/testing/dart/reset_safari.dart ('k') | tools/testing/dart/status_reporter.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/runtime_configuration.dart
diff --git a/tools/testing/dart/runtime_configuration.dart b/tools/testing/dart/runtime_configuration.dart
index 827ad08a884f28146285734aa3f71593cdf55b97..c57ba6584059e4ec1b175808adca40f335f53083 100644
--- a/tools/testing/dart/runtime_configuration.dart
+++ b/tools/testing/dart/runtime_configuration.dart
@@ -26,8 +26,8 @@ class RuntimeConfiguration {
// test_options.dart. We probably want to store an instance of
// [RuntimeConfiguration] in [configuration] there.
factory RuntimeConfiguration(Map<String, dynamic> configuration) {
- String runtime = configuration['runtime'];
- bool useBlobs = configuration['use_blobs'];
+ var runtime = configuration['runtime'] as String;
+ var useBlobs = configuration['use_blobs'] as bool;
switch (runtime) {
case 'ContentShellOnAndroid':
@@ -343,7 +343,7 @@ class SelfCheckRuntimeConfiguration extends DartVmRuntimeConfiguration {
return selfCheckers
.map((String tester) => commandBuilder.getVmBatchCommand(
executable, tester, arguments, environmentOverrides,
- checked: suite.configuration['checked']))
+ checked: suite.configuration['checked'] as bool))
.toList();
}
« no previous file with comments | « tools/testing/dart/reset_safari.dart ('k') | tools/testing/dart/status_reporter.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698