Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1424)

Unified Diff: chrome/browser/page_load_metrics/metrics_web_contents_observer.h

Issue 2903693004: Make PageLoadMetricsWaiter more resilient (Closed)
Patch Set: rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/metrics_web_contents_observer.h
diff --git a/chrome/browser/page_load_metrics/metrics_web_contents_observer.h b/chrome/browser/page_load_metrics/metrics_web_contents_observer.h
index 4f794b818a078c296bd08cc7c5a93a7189aaefc7..81b858b7a9e13e465fc7fe2b38b34a88846e8339 100644
--- a/chrome/browser/page_load_metrics/metrics_web_contents_observer.h
+++ b/chrome/browser/page_load_metrics/metrics_web_contents_observer.h
@@ -60,11 +60,7 @@ class MetricsWebContentsObserver
void OnGoingAway();
- // Invoked when a new PageLoadTiming update has been received and processed.
- virtual void OnTimingUpdated(bool is_main_frame,
- const mojom::PageLoadTiming& timing,
- const mojom::PageLoadMetadata& metadata) {}
-
+ virtual void OnCommit(PageLoadTracker* tracker) {}
virtual void DidReceiveTimingUpdate(IPCType type) {}
private:

Powered by Google App Engine
This is Rietveld 408576698