Make PageLoadMetricsWaiter more resilient

chrome/browser/page_load_metrics/metrics_web_contents_observer.cc

Index: chrome/browser/page_load_metrics/metrics_web_contents_observer.cc
diff --git a/chrome/browser/page_load_metrics/metrics_web_contents_observer.cc b/chrome/browser/page_load_metrics/metrics_web_contents_observer.cc
index 072f1b510545a10a919d715471a2208a1e9ab919..647cf08d1c529b8f09895419a9fef53b6def2b53 100644
--- a/chrome/browser/page_load_metrics/metrics_web_contents_observer.cc
+++ b/chrome/browser/page_load_metrics/metrics_web_contents_observer.cc
@@ -432,6 +432,9 @@ void MetricsWebContentsObserver::HandleCommittedNavigationForTrackedLoad(
   committed_load_ = std::move(tracker);
   committed_load_->Commit(navigation_handle);
   DCHECK(committed_load_->did_commit());
+
+  for (auto& observer : testing_observers_)

[Charlie Harrison, 2017/05/25 19:35:33]

nit: for loops in the file generally have braces.

[Bryan McQuade, 2017/05/25 19:54:05]

All of the other testing observer for loops don't use braces, so if it's ok I'd
like to stay consistent with those.

[Charlie Harrison, 2017/05/25 19:59:44]

Ah yea, only looked at those for loops close to this one. We should standardize
it in PLM code at some point but this is fine.

+    observer.OnCommit(committed_load_.get());
 }
 
 void MetricsWebContentsObserver::NavigationStopped() {
@@ -614,10 +617,6 @@ void MetricsWebContentsObserver::OnTimingUpdated(
 
   committed_load_->metrics_update_dispatcher()->UpdateMetrics(render_frame_host,
                                                               timing, metadata);
-
-  const bool is_main_frame = (render_frame_host->GetParent() == nullptr);
-  for (auto& observer : testing_observers_)
-    observer.OnTimingUpdated(is_main_frame, timing, metadata);
 }
 
 void MetricsWebContentsObserver::OnUpdateTimingOverIPC(