Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(437)

Issue 2903693002: Fix GN bootstrap (Closed)

Created:
3 years, 7 months ago by Paweł Hajdan Jr.
Modified:
3 years, 7 months ago
Reviewers:
Dirk Pranke, brettw
CC:
chromium-reviews, Dirk Pranke, tfarina, agrieve+watch_chromium.org, phajdan
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix GN bootstrap TBR=brettw BUG=none Review-Url: https://codereview.chromium.org/2903693002 . Cr-Commit-Position: refs/heads/master@{#474017} Committed: https://chromium.googlesource.com/chromium/src/+/797723cd4453d536fdedb083918537630aa81b2b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M tools/gn/bootstrap/bootstrap.py View 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 7 (4 generated)
Paweł Hajdan Jr.
Committed patchset #1 (id:1) manually as 797723cd4453d536fdedb083918537630aa81b2b (presubmit successful).
3 years, 7 months ago (2017-05-23 20:08:17 UTC) #3
Paweł Hajdan Jr.
TBR https://chromium.googlesource.com/chromium/src/+/b17ee3d6890cf542ff39366a5f6579d540314829/tools/gn/bootstrap/OWNERS
3 years, 7 months ago (2017-05-23 20:08:49 UTC) #5
Dirk Pranke
3 years, 7 months ago (2017-05-23 20:08:54 UTC) #7
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698