Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Issue 2903643002: PaymentHandler: Implement PaymentRequestEvent constructor. (Closed)

Created:
3 years, 7 months ago by zino
Modified:
3 years, 6 months ago
CC:
chromium-reviews, gogerald+paymentswatch_chromium.org, haraken, rouslan+payments_chromium.org, blink-reviews, mahmadi+paymentswatch_chromium.org, sebsg+paymentswatch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

PaymentHandler: Implement PaymentRequestEvent constructor. Need the constructor and init dictionary for compatibility with DOM events. This CL contains IDL change but blink-intent is not required because it is still behind runtime flag. Related spec link: https://w3c.github.io/payment-handler/#dom-paymentrequestevent https://w3c.github.io/payment-handler/#dom-paymentrequesteventinit BUG=661608, 720027 TEST=payment-request-event.html Review-Url: https://codereview.chromium.org/2903643002 Cr-Commit-Position: refs/heads/master@{#477382} Committed: https://chromium.googlesource.com/chromium/src/+/bb3f76109a2e6b8be54745b7235c650b7b6f77c1

Patch Set 1 #

Patch Set 2 : constructor #

Total comments: 2

Patch Set 3 : PaymentHandler: Implement PaymentRequestEvent constructor. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -10 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/payments/resources/payment-request-event.js View 1 1 chunk +43 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/payments/PaymentRequestEvent.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/payments/PaymentRequestEvent.cpp View 1 2 2 chunks +7 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/payments/PaymentRequestEvent.idl View 1 1 chunk +3 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/payments/PaymentRequestEventInit.idl View 1 1 chunk +3 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
zino
PTAL
3 years, 6 months ago (2017-06-02 18:06:41 UTC) #3
please use gerrit instead
LGTM % comment https://codereview.chromium.org/2903643002/diff/20001/third_party/WebKit/Source/modules/payments/PaymentRequestEvent.h File third_party/WebKit/Source/modules/payments/PaymentRequestEvent.h (right): https://codereview.chromium.org/2903643002/diff/20001/third_party/WebKit/Source/modules/payments/PaymentRequestEvent.h#newcode50 third_party/WebKit/Source/modules/payments/PaymentRequestEvent.h:50: PaymentRequestEvent(const AtomicString& type, const PaymentRequestEventInit&); Would ...
3 years, 6 months ago (2017-06-05 15:38:55 UTC) #4
zino
Thank you for review! https://codereview.chromium.org/2903643002/diff/20001/third_party/WebKit/Source/modules/payments/PaymentRequestEvent.h File third_party/WebKit/Source/modules/payments/PaymentRequestEvent.h (right): https://codereview.chromium.org/2903643002/diff/20001/third_party/WebKit/Source/modules/payments/PaymentRequestEvent.h#newcode50 third_party/WebKit/Source/modules/payments/PaymentRequestEvent.h:50: PaymentRequestEvent(const AtomicString& type, const PaymentRequestEventInit&); ...
3 years, 6 months ago (2017-06-06 15:03:12 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2903643002/40001
3 years, 6 months ago (2017-06-06 17:40:42 UTC) #8
commit-bot: I haz the power
3 years, 6 months ago (2017-06-06 19:59:21 UTC) #11
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/bb3f76109a2e6b8be54745b7235c...

Powered by Google App Engine
This is Rietveld 408576698