Add generated PKITS tests relating to certificate policies.

Add generated PKITS tests relating to certificate policies.

This adds stubs for all tests under:

  4.8 (Certificate Policies)
  4.9 (Require Explicit Policy)
  4.10 (Policy Mappings)
  4.11 (Inhibit Policy Mapping)
  4.12 (Inhibit Any Policy)

Note that this CL does not *run* the tests yet, it just updates the
generators.

BUG=634456, 634453, 634452
Review-Url: https://codereview.chromium.org/2903633005
Cr-Commit-Position: refs/heads/master@{#475089}
Committed: https://chromium.googlesource.com/chromium/src/+/c95383ac0847a949d9b54964d0c2cd7c2b253a31

[eroman, 2017-05-25 02:14:17]

The CQ bit was checked by eroman@chromium.org to run a CQ dry run

[eroman, 2017-05-25 02:14:38]

eroman@chromium.org changed reviewers:
+ mattm@chromium.org

[commit-bot: I haz the power, 2017-05-25 02:15:06]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-25 05:30:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-25 05:30:13]

Dry run: This issue passed the CQ dry run.

[mattm, 2017-05-25 22:11:16]

https://codereview.chromium.org/2903633005/diff/1/net/cert/internal/nist_pkit...
File net/cert/internal/nist_pkits_unittest.h (right):

https://codereview.chromium.org/2903633005/diff/1/net/cert/internal/nist_pkit...
net/cert/internal/nist_pkits_unittest.h:10: #include
"base/strings/string_split.h"
put in the .cc

https://codereview.chromium.org/2903633005/diff/1/net/cert/internal/nist_pkit...
net/cert/internal/nist_pkits_unittest.h:37: // The valueo f
"initial-inhibit-any-policy".
value of

https://codereview.chromium.org/2903633005/diff/1/net/third_party/nist-pkits/...
File net/third_party/nist-pkits/generate_tests.py (right):

https://codereview.chromium.org/2903633005/diff/1/net/third_party/nist-pkits/...
net/third_party/nist-pkits/generate_tests.py:123:
'.*this\s+test\s+be\s+validated\s+using\s+the\s*following\s+inputs:.*')
why \s* between "the" and "following"?

https://codereview.chromium.org/2903633005/diff/1/net/third_party/nist-pkits/...
net/third_party/nist-pkits/generate_tests.py:229: """This structure describes a
test inputs and outputs"""
add a todo for testing user-constrained-policy-set? (and maybe
authorities-constrained-policy-set?)

https://codereview.chromium.org/2903633005/diff/1/net/third_party/nist-pkits/...
net/third_party/nist-pkits/generate_tests.py:259:
initial_policy_set=[TEST_POLICY_2]),
what about 4.8.1 "4. default settings, but with initial-explicit-policy set and
initial-policy-set = {NIST-test-policy-1, NIST-test-policy-2}. The path should
validate successfully."?

[eroman, 2017-05-25 22:41:50]

The CQ bit was checked by eroman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-25 22:42:47]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[eroman, 2017-05-25 22:42:59]

https://codereview.chromium.org/2903633005/diff/1/net/cert/internal/nist_pkit...
File net/cert/internal/nist_pkits_unittest.h (right):

https://codereview.chromium.org/2903633005/diff/1/net/cert/internal/nist_pkit...
net/cert/internal/nist_pkits_unittest.h:10: #include
"base/strings/string_split.h"
On 2017/05/25 22:11:16, mattm wrote:
> put in the .cc

Done.

https://codereview.chromium.org/2903633005/diff/1/net/cert/internal/nist_pkit...
net/cert/internal/nist_pkits_unittest.h:37: // The valueo f
"initial-inhibit-any-policy".
On 2017/05/25 22:11:16, mattm wrote:
> value of

Done.

https://codereview.chromium.org/2903633005/diff/1/net/third_party/nist-pkits/...
File net/third_party/nist-pkits/generate_tests.py (right):

https://codereview.chromium.org/2903633005/diff/1/net/third_party/nist-pkits/...
net/third_party/nist-pkits/generate_tests.py:123:
'.*this\s+test\s+be\s+validated\s+using\s+the\s*following\s+inputs:.*')
On 2017/05/25 22:11:16, mattm wrote:
> why \s* between "the" and "following"?

Done (bad translation on my part).

I had to generalize the expression changing space to \s+ because some of the the
policy tests have line breaks in different places (although I didn't quite need
to replace every space as I did here).

https://codereview.chromium.org/2903633005/diff/1/net/third_party/nist-pkits/...
net/third_party/nist-pkits/generate_tests.py:229: """This structure describes a
test inputs and outputs"""
On 2017/05/25 22:11:16, mattm wrote:
> add a todo for testing user-constrained-policy-set? (and maybe
> authorities-constrained-policy-set?)

Done.

I don't think those are too important as far as the test coverage goes
(success/failure covers the interesting cases, and makes liberal use of
policyConstraints to aid with this).

But authorities-constrained-policy-set could be handy to support in the future.

https://codereview.chromium.org/2903633005/diff/1/net/third_party/nist-pkits/...
net/third_party/nist-pkits/generate_tests.py:259:
initial_policy_set=[TEST_POLICY_2]),
On 2017/05/25 22:11:16, mattm wrote:
> what about 4.8.1 "4. default settings, but with initial-explicit-policy set
and
> initial-policy-set = {NIST-test-policy-1, NIST-test-policy-2}. The path should
> validate successfully."?

Done.

Wow, not sure how that got missed! Thanks for spotting.

I will do another review pass of all the others in case I missed anything else
in the translation :(

[mattm, 2017-05-25 23:28:23]

lgtm

https://codereview.chromium.org/2903633005/diff/1/net/third_party/nist-pkits/...
File net/third_party/nist-pkits/generate_tests.py (right):

https://codereview.chromium.org/2903633005/diff/1/net/third_party/nist-pkits/...
net/third_party/nist-pkits/generate_tests.py:229: """This structure describes a
test inputs and outputs"""
On 2017/05/25 22:42:58, eroman wrote:
> On 2017/05/25 22:11:16, mattm wrote:
> > add a todo for testing user-constrained-policy-set? (and maybe
> > authorities-constrained-policy-set?)
> 
> Done.
> 
> I don't think those are too important as far as the test coverage goes
> (success/failure covers the interesting cases, and makes liberal use of
> policyConstraints to aid with this).
> 
> But authorities-constrained-policy-set could be handy to support in the
future.

sgtm.  (I think user-constrained-policy-set is actually the important one since
it's basically computed from the final valid_policy_tree, while
authorities-constrained-policy-set is the valid_policy_tree before its
intersection with user-initial-policy-set (which would probably not be feasible
to get with the way the policies are being implemented))

[eroman, 2017-05-26 00:01:47]

https://codereview.chromium.org/2903633005/diff/1/net/third_party/nist-pkits/...
File net/third_party/nist-pkits/generate_tests.py (right):

https://codereview.chromium.org/2903633005/diff/1/net/third_party/nist-pkits/...
net/third_party/nist-pkits/generate_tests.py:259:
initial_policy_set=[TEST_POLICY_2]),
On 2017/05/25 22:42:59, eroman wrote:
> On 2017/05/25 22:11:16, mattm wrote:
> > what about 4.8.1 "4. default settings, but with initial-explicit-policy set
> and
> > initial-policy-set = {NIST-test-policy-1, NIST-test-policy-2}. The path
should
> > validate successfully."?
> 
> Done.
> 
> Wow, not sure how that got missed! Thanks for spotting.
> 
> I will do another review pass of all the others in case I missed anything else
> in the translation :(

FTR: I reviewed all of the manual expectations, and also added the full text as
comments to make it a bit easier to check the subsequent translation.

I did not find any other omissions or errors, but did remove a few overrides
that could be handled through normal flow.

[eroman, 2017-05-26 00:19:56]

The CQ bit was checked by eroman@chromium.org

[eroman, 2017-05-26 00:19:56]

The patchset sent to the CQ was uploaded after l-g-t-m from mattm@chromium.org
Link to the patchset: https://codereview.chromium.org/2903633005/#ps60001
(title: "Update comments")

[commit-bot: I haz the power, 2017-05-26 00:20:40]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-26 04:50:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-26 04:50:48]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[eroman, 2017-05-26 18:32:51]

The CQ bit was checked by eroman@chromium.org

[commit-bot: I haz the power, 2017-05-26 18:33:26]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-26 19:37:33]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1495823571931130,
"parent_rev": "bc58befabe87e204650c836793204bac887992bd", "commit_rev":
"c95383ac0847a949d9b54964d0c2cd7c2b253a31"}

[commit-bot: I haz the power, 2017-05-26 19:37:46]

Description was changed from

==========
Add generated PKITS tests relating to certificate policies.

This adds stubs for all tests under:

  4.8 (Certificate Policies)
  4.9 (Require Explicit Policy)
  4.10 (Policy Mappings)
  4.11 (Inhibit Policy Mapping)
  4.12 (Inhibit Any Policy)

Note that this CL does not *run* the tests yet, it just updates the
generators.

BUG=634456,634453,634452
==========

to

==========
Add generated PKITS tests relating to certificate policies.

This adds stubs for all tests under:

  4.8 (Certificate Policies)
  4.9 (Require Explicit Policy)
  4.10 (Policy Mappings)
  4.11 (Inhibit Policy Mapping)
  4.12 (Inhibit Any Policy)

Note that this CL does not *run* the tests yet, it just updates the
generators.

BUG=634456,634453,634452

Review-Url: https://codereview.chromium.org/2903633005
Cr-Commit-Position: refs/heads/master@{#475089}
Committed:
https://chromium.googlesource.com/chromium/src/+/c95383ac0847a949d9b54964d0c2...
==========

[commit-bot: I haz the power, 2017-05-26 19:37:52]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/c95383ac0847a949d9b54964d0c2...